-
Notifications
You must be signed in to change notification settings - Fork 5
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Prevent infinite loop when error is thrown during
play
invocation
In case the play function throws an error, we didn't properly disambiguate it from the internal error thrown by `forceHappoScreenshot`. This caused the test suite to re-render the last step over and over (until eventually the browser crashed). To fix this, I'm adding a `done` boolean to the step created by forceHappoScreenshot. Each step is only allowed to be processed once. It's a little annoying that the `errored` event details do not contain any information about the thrown error. If it did, we wouldn't have to do this complicated detection to see if the error is ours or someone elses.
- Loading branch information
Showing
2 changed files
with
30 additions
and
4 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters