Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/extra resource loading from npm #784

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

jkiddo
Copy link
Collaborator

@jkiddo jkiddo commented Feb 23, 2025

This feature is backwards compatible and introduces the option to load e.g. example packages from IG's based on configuration

@jamesagnew
Copy link
Contributor

This functionality would probably make sense to just roll into the base PackageInstallationSpec. I'd rather not have this project implementing novel features not actually found in the base project, that's hard for support.

# Conflicts:
#	src/main/java/ca/uhn/fhir/jpa/starter/AppProperties.java
…dition

Added try-load of HAPI optimized dialect
@jkiddo
Copy link
Collaborator Author

jkiddo commented Feb 24, 2025

Sure ... I can make a PR to the base getting the additionalResourceFolders added the PackageInstallationSpec.

@jkiddo
Copy link
Collaborator Author

jkiddo commented Feb 24, 2025

@jamesagnew whats your take on the refactored version of the PostConstruct I've done here in https://github.com/hapifhir/hapi-fhir-jpaserver-starter/pull/784/files#diff-0f42a12718125be49d417ad9c402f5f2cecddfb7cb0ecfde364ad09132fa2a99R21 as mentioned in #758

@jkiddo
Copy link
Collaborator Author

jkiddo commented Feb 24, 2025

and btw - the same thing I did on https://github.com/hapifhir/hapi-fhir-jpaserver-starter/pull/784/files#diff-cca286d85a1c14aea8b529430ecd47aa4a803b53f4c7816deb7d602bd2af3268R11 can be done for a loooooong range of interceptor logic currently handled in the already way-too-big

method (I'm not pointing fingers here as I most likely authored a lot of it myself).

@jkiddo jkiddo marked this pull request as ready for review February 25, 2025 07:56
@jkiddo jkiddo requested a review from dotasek February 25, 2025 07:56
@jkiddo
Copy link
Collaborator Author

jkiddo commented Feb 27, 2025

@jamesagnew I'll move the additional sources logic once its been merged in here - acceptable for you? Then we can merge this into #785 and remove it from the starter as soon as it can be resolved from a snapshot in core.

# Conflicts:
#	src/main/java/ca/uhn/fhir/jpa/starter/AppProperties.java
# Conflicts:
#	src/main/java/ca/uhn/fhir/jpa/starter/AppProperties.java
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants