-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat/extra resource loading from npm #784
base: master
Are you sure you want to change the base?
Feat/extra resource loading from npm #784
Conversation
This functionality would probably make sense to just roll into the base PackageInstallationSpec. I'd rather not have this project implementing novel features not actually found in the base project, that's hard for support. |
# Conflicts: # src/main/java/ca/uhn/fhir/jpa/starter/AppProperties.java
…dition Added try-load of HAPI optimized dialect
Sure ... I can make a PR to the base getting the |
@jamesagnew whats your take on the refactored version of the |
and btw - the same thing I did on https://github.com/hapifhir/hapi-fhir-jpaserver-starter/pull/784/files#diff-cca286d85a1c14aea8b529430ecd47aa4a803b53f4c7816deb7d602bd2af3268R11 can be done for a loooooong range of interceptor logic currently handled in the already way-too-big hapi-fhir-jpaserver-starter/src/main/java/ca/uhn/fhir/jpa/starter/common/StarterJpaConfig.java Line 262 in 792f520
|
@jamesagnew I'll move the additional sources logic once its been merged in here - acceptable for you? Then we can merge this into #785 and remove it from the starter as soon as it can be resolved from a snapshot in core. |
# Conflicts: # src/main/java/ca/uhn/fhir/jpa/starter/AppProperties.java
# Conflicts: # src/main/java/ca/uhn/fhir/jpa/starter/AppProperties.java
This feature is backwards compatible and introduces the option to load e.g. example packages from IG's based on configuration