Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider adding spotless and error prone to github actions #747

Open
jkiddo opened this issue Oct 4, 2024 · 4 comments
Open

Consider adding spotless and error prone to github actions #747

jkiddo opened this issue Oct 4, 2024 · 4 comments
Assignees
Labels
question Further information is requested

Comments

@jkiddo
Copy link
Collaborator

jkiddo commented Oct 4, 2024

Should we consider adding spotless and/or errorprone to the github actions?

@jkiddo jkiddo added the question Further information is requested label Oct 4, 2024
@joofio
Copy link

joofio commented Oct 4, 2024

Can you explain what that means?

@jkiddo
Copy link
Collaborator Author

jkiddo commented Oct 4, 2024

Spotless: https://github.com/diffplug/spotless
Errorproine: https://github.com/google/error-prone

@joofio
Copy link

joofio commented Oct 4, 2024

github action or precommit hook? (or both?)

@dotasek
Copy link
Contributor

dotasek commented Oct 8, 2024

HAPI itself uses spotless checks both as action and pre-commit, so adopting that seems entirely appropriate.

Actually, I haven't seen a spotless complaint from my HAPI git command line lately. Only checkstyle failures in the PR checks. I think I will go check if spotless is working for pre-commits...

I'll bring up error prone with some of the dev team. It's present in the codebase, but doesn't seem to be actively checked by anything.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

3 participants