Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FR] Support grafana alerting #15

Closed
Nobodyno-boop opened this issue Oct 14, 2024 · 7 comments
Closed

[FR] Support grafana alerting #15

Nobodyno-boop opened this issue Oct 14, 2024 · 7 comments

Comments

@Nobodyno-boop
Copy link
Contributor

Hello, i hope your doing great!

For my purpose i need the alert query by grafana, are open to support this feature ? (https://grafana.com/developers/plugin-tools/tutorials/build-a-data-source-backend-plugin#enable-grafana-alerting) I'd be happy to help you with this feature.

Best regards :D

@haohanyang
Copy link
Owner

Sure! It's a big missing from v0.1.0 release. Feel free to craft it.

@Nobodyno-boop
Copy link
Contributor Author

Its a bit ridiculus, just a "alerting": true, in the plugin.json, you can enable if you want without any change in the code. But maybe we need some review.

Will actually test it in stagging on a project in few days and hope we not gonna need some some change.

However, it might be interesting to activate the query concurrently ?
https://grafana.com/developers/plugin-tools/tutorials/build-a-data-source-backend-plugin#run-multiple-queries-concurrently

@haohanyang
Copy link
Owner

Any new update on this proposal? @Nobodyno-boop

@fonzi
Copy link

fonzi commented Dec 6, 2024

I saw that @haohanyang enabled in the latest commit to master. Appears that I can add the Mongo Datasource.

Still testing...

image

@fonzi
Copy link

fonzi commented Dec 6, 2024

Following up, appears that the latest master push works with alerts.

image

@haohanyang
Copy link
Owner

This has been now released in the latest version

@Nobodyno-boop
Copy link
Contributor Author

Nobodyno-boop commented Dec 19, 2024

Seems to be worked well on in production test for me.
If its good to you we can close this issue.

Sorry for late reply!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants