Delete children automatically through foreign key definition;

migrations/2021_5_29_100000_create_resources_table.php

@@ -1,42 +1,42 @@
 <?php
 
-    use Illuminate\Database\Migrations\Migration;
-    use Illuminate\Database\Schema\Blueprint;
-    use Illuminate\Support\Facades\Schema;
+use Illuminate\Database\Migrations\Migration;
+use Illuminate\Database\Schema\Blueprint;
+use Illuminate\Support\Facades\Schema;
 
-    return new class() extends Migration {
-        /**
-         * Run the migrations.
-         *
-         * @return void
-         */
-        public function up()
-        {
-            Schema::create('resources', function (Blueprint $table) {
-                $table->id();
+return new class() extends Migration {
+    /**
+     * Run the migrations.
+     *
+     * @return void
+     */
+    public function up(): void
+    {
+        Schema::create('resources', function (Blueprint $table) {
+            $table->id();
 
-                $table->foreignId('parent_id')->nullable()->constrained()->cascadeOnDelete();
+            $table->foreignId('parent_id')->nullable()->constrained('resources')->cascadeOnDelete();
 
-                $table->string('title');
-                $table->string('directory')->nullable();
-                $table->string('file')->nullable();
-                $table->string('hls')->nullable();
-                $table->string('link')->nullable();
-                $table->string('extension', 50);
-                $table->text('options')->nullable();
-                $table->boolean('external')->default(false);
+            $table->string('title');
+            $table->string('directory')->nullable();
+            $table->string('file')->nullable();
+            $table->string('hls')->nullable();
+            $table->string('link')->nullable();
+            $table->string('extension', 50);
+            $table->text('options')->nullable();
+            $table->boolean('external')->default(false);
 
-                $table->timestamps();
-            });
-        }
+            $table->timestamps();
+        });
+    }
 
-        /**
-         * Reverse the migrations.
-         *
-         * @return void
-         */
-        public function down()
-        {
-            Schema::dropIfExists('resources');
-        }
-    };
+    /**
+     * Reverse the migrations.
+     *
+     * @return void
+     */
+    public function down(): void
+    {
+        Schema::dropIfExists('resources');
+    }
+};

src/Services/Actions/Delete.php

@@ -29,11 +29,6 @@ public function run(): Resource
         DB::beginTransaction();
 
         try {
-            if ($this->model->children()->exists()) {
-                foreach ($this->model->children()->select('id', 'directory', 'external')->get() as $child) {
-                    ( new self($child) )->run();
-                }
-            }
             $this->model->delete();
             if (!$this->model->isExternal() and alicia_storage()->exists($this->model->directory)) {
                 alicia_storage()->deleteDirectory($this->model->directory);

tests/TestCase.php

@@ -6,6 +6,7 @@
 use Illuminate\Foundation\Application;
 use Illuminate\Foundation\Testing\RefreshDatabase;
 use Illuminate\Routing\Router;
+use Illuminate\Support\Facades\DB;
 use Orchestra\Testbench\TestCase as BaseTestCase;
 
 class TestCase extends BaseTestCase
@@ -21,6 +22,7 @@ protected function setUp(): void
     {
         parent::setUp();
 
+        DB::statement('PRAGMA foreign_keys = ON;'); // It's disabled in Sqlite by default
         $this->loadMigrationsFrom(__DIR__.'/Core/migrations');
     }
 

tests/Unit/ResourceModelTest.php

@@ -4,9 +4,12 @@
 
 use Hans\Alicia\Facades\Alicia;
 use Hans\Alicia\Facades\Signature;
+use Hans\Alicia\Models\Resource;
 use Hans\Alicia\Tests\TestCase;
 use Illuminate\Http\UploadedFile;
+use Illuminate\Support\Facades\DB;
 use Illuminate\Support\Facades\URL;
+use Spatie\Image\Exceptions\InvalidManipulation;
 use Symfony\Component\HttpFoundation\BinaryFileResponse;
 
 class ResourceModelTest extends TestCase
@@ -286,4 +289,23 @@ public function isNotExternal(): void
         self::assertTrue($model->isNotExternal());
         self::assertFalse($model->isExternal());
     }
+
+    /**
+     * @test
+     *
+     * @return void
+     * @throws InvalidManipulation
+     */
+    public function childrenDeletedAutomatically(): void
+    {
+        $model = Alicia::upload(
+            UploadedFile::fake()->image('g-eazy.png', 1080, 1080)
+        )
+                       ->export([540 => 540, 480 => 480])
+                       ->getData();
+
+        Alicia::delete($model->get('parents')->pluck('id')->first());
+
+        self::assertEmpty(DB::table('resources')->get()->pluck('id'));
+    }
 }