Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[vulkan] performance_wrap test results don't match #7559

Closed
derek-gerstmann opened this issue May 9, 2023 · 1 comment
Closed

[vulkan] performance_wrap test results don't match #7559

derek-gerstmann opened this issue May 9, 2023 · 1 comment
Assignees
@derek-gerstmann

Comments

@derek-gerstmann
Copy link
Contributor

derek-gerstmann commented May 9, 2023 •
edited
Loading

There appear to be some incorrect results in the performance_wrap test for shared memory that need investigating:

HL_JIT_TARGET=host-vulkan-vk_int8-vk_int16-vk_int64-vk_float16-vk_float64-vk_v13 ./build/test/performance/performance_wrap 
wrapper(1, 0) = 90 instead of 0
wrapper(2, 0) = 180 instead of 0
wrapper(3, 0) = 270 instead of 0
@derek-gerstmann derek-gerstmann self-assigned this May 9, 2023
derek-gerstmann pushed a commit that referenced this issue May 9, 2023
Disable test for Vulkan since shared memory results are incorrect (se…
24ff554 
…e issue #7559)
@derek-gerstmann derek-gerstmann mentioned this issue May 9, 2023
Merged
steven-johnson pushed a commit that referenced this issue May 10, 2023
@derek-gerstmann
[vulkan] Disable performance_wrap test for Vulkan ... results don't m…
afea893 
…atch (#7560)

* Fix missing initializer for vulkan memory config that got munged in a previous merge.
This gets the correctness_multiple_outputs test to pass.

* Disable test for Vulkan since shared memory results are incorrect (see issue #7559)

* Clang tidy/format pass

---------

Co-authored-by: Derek Gerstmann <dgerstmann@adobe.com>
ardier pushed a commit to ardier/Halide-mutation that referenced this issue Mar 3, 2024
@derek-gerstmann @ardier
[vulkan] Disable performance_wrap test for Vulkan ... results don't m…
3d7f686 
…atch (halide#7560)

* Fix missing initializer for vulkan memory config that got munged in a previous merge.
This gets the correctness_multiple_outputs test to pass.

* Disable test for Vulkan since shared memory results are incorrect (see issue halide#7559)

* Clang tidy/format pass

---------

Co-authored-by: Derek Gerstmann <dgerstmann@adobe.com>
@derek-gerstmann
Copy link
Contributor Author

Fixed in #8448 . Test re-enabled in #8452.

@derek-gerstmann derek-gerstmann mentioned this issue Oct 31, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@derek-gerstmann derek-gerstmann

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@derek-gerstmann