Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pins 'xgcm<0.7' and add more grid variables #244

Merged
merged 3 commits into from
Jul 25, 2022

Conversation

Mikejmnez
Copy link
Collaborator

This quick PR addresses #243 and #234 .

@codecov
Copy link

codecov bot commented Jul 25, 2022

Codecov Report

Merging #244 (0186f93) into main (2899047) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##             main     #244   +/-   ##
=======================================
  Coverage   95.59%   95.59%           
=======================================
  Files          10       10           
  Lines        3634     3634           
  Branches      773      773           
=======================================
  Hits         3474     3474           
  Misses        109      109           
  Partials       51       51           
Flag Coverage Δ
unittests 95.59% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Help us with your feedback. Take ten seconds to tell us how you rate us.

@Mikejmnez
Copy link
Collaborator Author

Note that while this PR closes #234, but we should keep #243 open as this PR is just a temporary fix.

@Mikejmnez
Copy link
Collaborator Author

Mikejmnez commented Jul 25, 2022

These are really minor changes, so I'll just go ahead and merge.

@Mikejmnez Mikejmnez merged commit 647e07a into hainegroup:main Jul 25, 2022
Mikejmnez pushed a commit that referenced this pull request Jul 25, 2022
@Mikejmnez Mikejmnez deleted the iss243 branch July 25, 2022 19:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant