-
-
Notifications
You must be signed in to change notification settings - Fork 801
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removed Emily Eldar's leadership variable #7936
base: gh-pages
Are you sure you want to change the base?
Removed Emily Eldar's leadership variable #7936
Conversation
Want to review this pull request? Take a look at this documentation for a step by step guide! From your project repository, check out a new branch and test the changes.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Title needs to be more specific, and reason for change needs to be more specific. Please check the CodeQL options.
Requested change: Before and After Images links are broken.
- pr links to issue correctly
- changes are clean and useful
All other changes are great, Thank you for your hard work.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please review requirements, working before and after images need to be uploaded before approval.
All other changes look great and the issue will be approved once proper documentation of before and after images have been properly uploaded.
@rogerioduenas , please comment with your |
Review ETA: EOD 2/26/25 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @Christopher-Chhim , thank you for taking on this issue.
Things you did well:
- PR is done with the correct branch.
- PR contains correctly formatted linked issue.
- PR follows correct format.
- The changes are applicable to the issue.
- Website is still user-friendly and links and components still work as intended.
- Source code changes are applicable and clean.
Suggested changes:
- Under “what changes did you make,” please be more specific on which markdown file did you remove the project profile from:
_projects/home-unite-us.md
. - Under “why did you make the changes,” please make your reason relevant to the issue and something like
To keep list of active HfLA project profiles up-to-date
. - CodeQL Alerts have not been properly checked. Please check if PR had any CodeQL alerts. Then, please check the correct checkbox on this PR under “CodeQL Alerts”.
- Before and after screenshots are not appropriately included and do not properly load. Please drag and drop the screenshot images and wait for them to finish uploading.
Notes:
- In the future, please make your issue branch name more detailed and relate it to the issue. Please follow the correct scheme/format. For example, the issue Update ‘Give’ image credit link and information - #2093 should have this branch name:
update-give-link-2093
. No need to change the issue branch name for this issue.
After making these changes, re-request a review from me. Thank you for your hard work!
Availability: Monday - Friday, 10:00 AM to 4:00 PM JST |
I can't access my local repository's live server so I can't provide a picture for after the changes have been applied but I believe it will work. |
Hello @Christopher-Chhim :) I saw here and it seems that you corrected everything that was necessary for your PR to be approved, but putting the photo after the task was done is important, even if it is possible to run your branch locally on the reviewer's machine, it is important that you can complete all the steps for your PR to be approved. |
Fixes #7484
What changes did you make?
Why did you make the changes (we will use this info to test)?
CodeQL Alerts
After the PR has been submitted and the resulting GitHub actions/checks have been completed, developers should check the PR for CodeQL alert annotations.
Check the PR's comments. If present on your PR, the CodeQL alert looks similar as shown
Please let us know that you have checked for CodeQL alerts. Please do not dismiss alerts.
Instructions for resolving CodeQL alerts
If CodeQL alert/annotations appear, refer to How to Resolve CodeQL alerts.
In general, CodeQL alerts should be resolved prior to PR reviews and merging
Screenshots of Proposed Changes To The Website (if any, please do not include screenshots of code changes)
Visuals before changes are applied

Visuals after changes are applied