Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bugfix: Searching an address outside of an NC boundary silently fails #1840

Open
1 task
ryanfchase opened this issue Oct 3, 2024 · 1 comment
Open
1 task

Bugfix: Searching an address outside of an NC boundary silently fails #1840

ryanfchase opened this issue Oct 3, 2024 · 1 comment
Labels
Bug Something isn't working Complexity: Small Good First Issue Good for newcomers P-feature: Map P-feature: Search/Filter Modal Role: Frontend React front end work size: 0.25pt Can be done in 1.5 hours
Milestone
05 - Bug Bash

Comments

@ryanfchase
Copy link
Member

Overview

We need to fix a regression so that users can still look up addresses outside of NC boundaries.

Action Items

  • Modify behavior of the else block on L553
    • if ncIdOfAddressSearch is empty, still attempt to set the address state so that a geocoder pin is placed

Dev Resources

Useful Files and Components

  • MapSearch.jsx (see props)
  • Map.jsx (see L534, onGeocoderResult(result)

Mapbox Docs

Resources/Instructions

Screen recording after proposed changes

[insert screenshot here]

@ryanfchase ryanfchase added Bug Something isn't working Good First Issue Good for newcomers Role: Frontend React front end work P-feature: Map size: 0.25pt Can be done in 1.5 hours P-feature: Search/Filter Modal Complexity: Small labels Oct 3, 2024
@ryanfchase ryanfchase added this to the 05 - Bug Bash milestone Oct 3, 2024
@ryanfchase ryanfchase mentioned this issue Oct 3, 2024
Open
4 tasks
@ryanfchase
Copy link
Member Author

I'm opening this up as ready to work on. Smaller than 1pt, skipping dev lead review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Something isn't working Complexity: Small Good First Issue Good for newcomers P-feature: Map P-feature: Search/Filter Modal Role: Frontend React front end work size: 0.25pt Can be done in 1.5 hours
Projects
P: 311: Project Board
Status: Prioritized Backlog
Milestone
05 - Bug Bash
Development

No branches or pull requests
1 participant
@ryanfchase