Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MoonlitRoad-Ben #874

Merged
merged 3 commits into from
Sep 4, 2024
Merged

MoonlitRoad-Ben #874

merged 3 commits into from
Sep 4, 2024

Conversation

SlightlyLessBigJimmy
Copy link
Contributor

My art piece is titled "Moonlit Road" because it is exactly as it says, a picture of a road on a landscape, with a moon and stars. The piece will generate differently each time, with the horizon line changing, grass being drawn, the stars being placed, scaled, and shaped randomly, and the road will follow where it should be according to the horizon line. My favorite part is the moon, however because it will have a randomly decided phase based on 3 different moon types. During the process of making this piece, I learned a new language, Javascript, and a new use for programming, Art! I never thought about making pictures with code before this.
1

Copy link

vercel bot commented Aug 27, 2024

@SlightlyLessBigJimmy is attempting to deploy a commit to the Hack Club Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

github-actions bot commented Aug 27, 2024

art/MoonlitRoad-Ben/index.js looks like art! preview it in the editor

@Dongathan-Jong Dongathan-Jong self-assigned this Aug 27, 2024
@Dongathan-Jong
Copy link
Collaborator

Super sick piece! However, in some instances, the lines do go out of the canvas, could you fix that? I think it would also be super cool if you added a cloud or two in there :)

@SlightlyLessBigJimmy
Copy link
Contributor Author

Super sick piece! However, in some instances, the lines do go out of the canvas, could you fix that? I think it would also be super cool if you added a cloud or two in there :)

I don't see any of the lines going outside the canvas unless some values are changed to very high levels, do I need to put a cap on some values to prevent this? I just assumed people wouldn't make them that high.

@Dongathan-Jong
Copy link
Collaborator

I think it's with the box where the lines spawn in from, you can see sometimes it goes out of the canvas under the blue line. Also, the stars sometimes go into the hill. Once you fix these I can forward this to Alex for approval!
image
image

@SlightlyLessBigJimmy
Copy link
Contributor Author

I see, thanks!

fixed stars spawning below horizon and grass spawning above horizon/ out of canvas
@SlightlyLessBigJimmy
Copy link
Contributor Author

I think it's with the box where the lines spawn in from, you can see sometimes it goes out of the canvas under the blue line. Also, the stars sometimes go into the hill. Once you fix these I can forward this to Alex for approval! image image

I have fixed the issues now, and committed the changes to index.js, that should update it correctly, right?

@Dongathan-Jong
Copy link
Collaborator

Great thank you! I will forward this, please wait as there will be an update soon (anywhere from a couple days to a week) in this PR whether you need a bit more of you've been accepted! Great work :)

@SlightlyLessBigJimmy
Copy link
Contributor Author

SlightlyLessBigJimmy commented Sep 1, 2024 via email

Copy link
Member

@qcoral qcoral left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This art piece is awesome! Thank you @Dongathan-Jong for reviewing this. Congrats on your new Blot! You can order one here

@qcoral qcoral merged commit e7744e0 into hackclub:main Sep 4, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants