-
Notifications
You must be signed in to change notification settings - Fork 517
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Baseballfield-Ventengo #830
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It doesn't look like this piece is generative!
What do you mean by generative? I have lots of variables throughout the code which can be changed altering the image. For example the large curve on the left side of the image can be flipped or the amount of arc can be changed layering how it would look. Also the size of the squares can also be changed altering the look. |
There are more examples too with the positions of the squares, the size of the circle in the middle, and more |
Hey, I did a check and this is indeed generative, but 2 things:
I'll swing back around later, thanks for the wait! |
Updated code by moving all variables to top and adding another element which is mountains. I did this after one of my favorite baseball teams the Colorado Rockies. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is better, but still could use some more work. Also, can you move the variables at the top? Makes it much easier for someone to see the different generations of your artwork!
All the variables are at the top |
@Ventengo1 is attempting to deploy a commit to the Hack Club Team on Vercel. A member of the Team first needs to authorize it. |
How do I chance the pic 1, pic 2, and pic 3, file to the new images |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is getting there!! But there's still a ton of overlapping & generally unpolished parts. Can you try and clean things up? I'm specifically looking at the players, as I'm pretty sure they aren't so uncoordinated in real baseball :)
Made it look a lot more realistic by adding people at the bases and on the field |
Hi there, |
Keep working on your PR! Just an update, I am going to close this PR. Please create a new PR once you have updated your art. I am doing this due to a new management system for the PRs. |
My art piece is of a baseball field. I included the infield with the four bases as well as the pitchers mound. I also included the outfield fence and made sure to leave room past it just like in a real field. I have some experience coding in Java script but more in other languages. I learned a lot while coding this project.
Math.random()
(See the documentation on randomness)If you used based your art on something else, used a tutorial, or remixed it from something else, please link it here: https://blot.hackclub.com/editor?guide=start