Re-add improved error messages with fixes #784
Conversation
Fix bugs that were discovered when testing the new error message system against every gallery function and open PR. It fixes a number of subtle logic bugs, adds a new "numberArray" type for the bt.noise function, and improves performance by not checking every element of large arrays. This commit is a combination of the following 7 commits: Fix bug in noise.js to satisfy assertions Make logic for determining the type of an array more accurate and robust Add numberArray type for the bt.noise function Correctly mark the second argument to bt.simplify as optional Make a point count as a numberArray Fix handling of special case expected types within arrays Correct the implementation of numberArray to apply to any size of array
…ions These 9 projects in the gallery were using built-in functions incorrectly, which triggered the new assertion errors. The changes made to fix these projects are as follows: - GSLV.Mk.III by Samrat - removed an extra wrapper array - Gallifreyan by Shav Kinderlehrer - removed empty placeholder arrays - tennis racket by ahowden27 - removed extra wrapper arrays - UnionedPolygons by sosenteam - converted multiple arguments into array - cloudyFibonacci by Yohance - corrected array access syntax - Blot Raytracer (Ascii Art) by HyperTNTClown - removed empty placeholder arrays - knight by krisk - removed a spurious array element - Procedural City by Elijah Bodden - converted points to 2D before using toolkit functions - Generic 3D Bed Slinger by Joshua Vinod - removed extra arguments
|
|
|
Going to merge this for now, if it causes issues I will revert! |
This PR is a fixed version of the original PR (#717). It caused errors in projects that people had already made. This version has been tested on every project in the gallery, as well as every open PR, and every issue has been solved.
Summary of the affected projects
Gallery projects
Open PRs
Original description (from #717)
This PR improves error messages significantly:
Before this change:
![Line 0: undefined is not a function (near '...[o,u]...')](https://private-user-images.githubusercontent.com/167175925/350134341-8bfef329-4530-485f-b0c5-6a96f6337746.jpeg?jwt=eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJpc3MiOiJnaXRodWIuY29tIiwiYXVkIjoicmF3LmdpdGh1YnVzZXJjb250ZW50LmNvbSIsImtleSI6ImtleTUiLCJleHAiOjE3NDAxMjI4ODgsIm5iZiI6MTc0MDEyMjU4OCwicGF0aCI6Ii8xNjcxNzU5MjUvMzUwMTM0MzQxLThiZmVmMzI5LTQ1MzAtNDg1Zi1iMGM1LTZhOTZmNjMzNzc0Ni5qcGVnP1gtQW16LUFsZ29yaXRobT1BV1M0LUhNQUMtU0hBMjU2JlgtQW16LUNyZWRlbnRpYWw9QUtJQVZDT0RZTFNBNTNQUUs0WkElMkYyMDI1MDIyMSUyRnVzLWVhc3QtMSUyRnMzJTJGYXdzNF9yZXF1ZXN0JlgtQW16LURhdGU9MjAyNTAyMjFUMDcyMzA4WiZYLUFtei1FeHBpcmVzPTMwMCZYLUFtei1TaWduYXR1cmU9MzE2YjAxY2QxNzAxOTQ5OGIxZGZiYzk0N2RhY2E4ZGM4N2M5NDE5MjEyMWFkN2I2ZWE0NGI4YzhlMDM5NTZmOCZYLUFtei1TaWduZWRIZWFkZXJzPWhvc3QifQ.fzi4hv2jyoT6iJpRt2Ep8RFe9XTJW3Fi6HwvUtDedtI)
This adds assertations to all of the built-in functions in Blot to throw meaningful errors when the wrong arguments are passed. It also upgrades the stack trace parsing logic, using V8's object representation and a regex built based on the SpiderMonkey and JavaScriptCore source code. Safari (JavaScriptCore) does not keep track of line numbers within eval'd code, so a hack is used to construct a data URL and import it when it is detected to be nessesary.
The previous version of Blot would give unhelpful errors like "t is not defined" on line 0, and line numbers only ever worked on Chrome in some cases. Now, it will give helpful errors explaining what went wrong, pointing to the correct position in the code on any browser.
There is a known issue where, on Safari, the stack does not follow nesting, so if the user defines a function, the error will appear where the function is called instead of within the function, but
there is no way to fix this.