-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Made Initial component for WelcomeEmail #21
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice work, just gotta polish it up a bit to keep our repo consistent and fix that rendering issue
Firstly, the PR title rules have that initial verb be lowercase; So it would be feat
not Feat
Make sure you have the ESLint VSCode extension installed to fix all warnings and errors in the future!
Merge with main to get the PNG logo (which will also make certain linting rules fail the build)
For future testing, use pnpm run email-dev
Also, you can update the sendWelcomeEmail server action to render your component as the HTML? Then, to test it finally, make a button on the client component send page that when you click it sends the email.
See step 3 with the render function: https://react.email/docs/integrations/nodemailer
Everything looks good on my end |
Description
Replaced the stripe-welcome.tsx with WelcomeEmail.tsx Basically just took the email from stripe and Changed the wording, links, logo, etc.
Can be tested with the following code in
src/app/page.tsx
I wanted to note that there is a hydration error when testing it this way. I believe this is just an error for how it's being rendered in the browser instead of an email, but I'm not sure.
Relevant Issues
Closes #10 - Create Welcome Email