Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

351 sort everything by name #372

Merged
merged 23 commits into from
May 2, 2024
Merged

351 sort everything by name #372

merged 23 commits into from
May 2, 2024

Conversation

andlrutt
Copy link
Member

@andlrutt andlrutt commented May 1, 2024

Description

Apply sorting to all lists

Covered the following lists:

  • Organization list (by name)
  • Volunteer list (by last name)
  • User list on settings page (by full name -- can't separate them out)
  • event list on volunteer page (by date)
  • Volunteer list on event page (by last name)
  • Volunteer list on organization page (by last name)
  • Organization list on volunteer page (via reporting -- from this PR )
  • First/Last/Email on CheckIn form
  • Also removed duplicates from first/last/email on checkin form

Did NOT cover the events list, since that is a bit more complex and will be covered by #242.

Relevant issue(s)

Questions

Please confirm that we should be sorting by last name when possible. First name is still displayed first, but last name is usually the go-to.

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have assigned reviewers to this PR

Copy link

vercel bot commented May 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
compassion-ministries ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 8:37pm

@andlrutt andlrutt changed the base branch from 201-add-reporting-to-volunteer-component to main May 1, 2024 20:29
@andlrutt andlrutt linked an issue May 1, 2024 that may be closed by this pull request
@zaviermiller zaviermiller merged commit 8cdb054 into main May 2, 2024
3 checks passed
@zaviermiller zaviermiller deleted the 351-sort-everything-by-name branch May 2, 2024 03:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sort everything by name
2 participants