Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

270 display sent emails #362

Merged
merged 16 commits into from
May 1, 2024
Merged

270 display sent emails #362

merged 16 commits into from
May 1, 2024

Conversation

ethanhmaness
Copy link
Contributor

@ethanhmaness ethanhmaness commented May 1, 2024

Description

Changed zod type of sentDate field of emails from string to date.
Created EmailList component and added to Event component to display sent emails.
Moved "Send Email" UI from EventView into the Event component.

Relevant issue(s)

#270

Questions

Type of change

  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have assigned reviewers to this PR

to test

Go to the Event page for any Event in the database (make sure it has an emails field with an array of objects matching the zod typedef). If emails is empty, it should render a disabled accordion, and if not, it should render a populated accordion with the details for each email object.

@ethanhmaness ethanhmaness linked an issue May 1, 2024 that may be closed by this pull request
Copy link

vercel bot commented May 1, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
compassion-ministries ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 2:56pm

andlrutt
andlrutt previously approved these changes May 1, 2024
@ethanhmaness ethanhmaness merged commit 1f0c7f2 into main May 1, 2024
3 checks passed
@ethanhmaness ethanhmaness deleted the 270-display-sent-emails branch May 1, 2024 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Display sent emails
2 participants