242 create intentional sorting on the events page #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ministries into 242-create-intentional-sorting-on-the-events-page
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
zaviermiller
requested changes
Apr 29, 2024
src/views/EventsView/index.tsx
Outdated
Comment on lines
39
to
40
| let upcomingEvents: EventResponse[]; | ||
| let pastEvents: EventResponse[]; |
There was a problem hiding this comment.
you can use const. instead of declaring the variables up here, just declare them where you give them a value below, ie const upcomingEvents = sortEventsByDateAsc(eventsTodayAndAfter) on line 46
zaviermiller
approved these changes
May 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Relevant issue(s)
#242
Questions
Type of change
Checklist: