266 create server funcapi endpoint for updating allowed users #346
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
#266
Questions
It seems sketchy to be overwriting the Settings schema directly from the server func, but there's no existing server func for adding emails to the Settings schema.
It also seems sketchy to just pass the request directly into the server func, though that's what the issue said to do. Should we validate that the user ids correspond to actual users first?
Type of change
Checklist:
To test
Log in as an admin and send a PUT request to
/api/users
that looks something like thisSend it a second time to check that it doesn't add duplicate emails.
NOTE: You can't use Postman for this, gotta do it directly thru the browser so your account can be authenticated.