283 create api endpointserver func to delete allowed logins #345
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
This reverts commit d387ffc.
src/server/actions/Setting.ts
Outdated
Comment on lines
10
to
30
| try { | ||
| dbConnect(); | ||
| doc = await getSettings() | ||
| } catch (error) { | ||
| throw new CMError(CMErrorType.InternalError) | ||
| } | ||
|
|
||
| const index = doc.allowedEmails.indexOf(email) | ||
| // No matching email found in email document | ||
| if (index == -1) { | ||
| throw new CMError(CMErrorType.NoSuchKey, "Email") | ||
| } else { | ||
| // Modifies array in-place | ||
| doc.allowedEmails.splice(index, 1) | ||
| // Set database obj array to modified array of retrieved document | ||
| await SettingsSchema.updateOne({ _id: doc._id }, { allowedEmails: doc.allowedEmails }) | ||
|
|
||
| // Delete associated user if one exists | ||
| try { | ||
| await UserSchema.findOneAndRemove({ email: email }) | ||
| } catch (e) { } |
There was a problem hiding this comment.
why are there two try catches here?
There was a problem hiding this comment.
First try catch is for throwing error if database call fails. Second try-catch never throws an error, it's just necessary to delete a user with the given email if one exists and to do nothing if one doesn't exist.
zaviermiller
approved these changes
Apr 30, 2024
ethanhmaness
deleted the
283-create-api-endpointserver-func-to-delete-allowed-logins
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Added
removeAllowedEmail()insrc/server/actions/Setting.tswhich removes an email from the allowed emails list in the settings document and deletes a user if there is a user associated with that email.Added API endpoint at DELETE
/api/settings/emailsand associated zod types to callremoveAllowedEmail().Relevant issue(s)
#283
Questions
Should this include authorization?
Do we want to move this to
Settings.ts?Type of change
Checklist:
To test
Log in as an admin and hit DELETE
/api/settings/emails?email=<email to delete>.