Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

252 add frontend support for updating events #336

Merged
merged 12 commits into from
May 1, 2024
Merged

252 add frontend support for updating events #336

merged 12 commits into from
May 1, 2024

Conversation

Frank-D-stein
Copy link
Contributor

@Frank-D-stein Frank-D-stein commented Apr 23, 2024 •
edited
Loading

Description

Added frontend support for updating events.

Relevant issue(s)

Questions

no questions

Type of change

  • New feature (non-breaking change which adds functionality)

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • I have assigned reviewers to this PR

@Frank-D-stein Frank-D-stein linked an issue Apr 23, 2024 that may be closed by this pull request
Add frontend support for updating events #252
Closed
@vercel Vercel
Copy link

vercel bot commented Apr 23, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
compassion-ministries ✅ Ready (Inspect) Visit Preview 💬 Add feedback May 1, 2024 6:55pm

zaviermiller
zaviermiller previously requested changes Apr 24, 2024
View reviewed changes
Copy link
Contributor

@zaviermiller zaviermiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

also it doesn't work.

src/app/events/[eventId]/edit/page.tsx Outdated Show resolved Hide resolved
src/types/forms/events.ts Outdated Show resolved Hide resolved
andlrutt
andlrutt previously approved these changes Apr 28, 2024
View reviewed changes
zaviermiller
zaviermiller previously approved these changes May 1, 2024
View reviewed changes
Copy link
Contributor

@zaviermiller zaviermiller left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fix merge

@Frank-D-stein Frank-D-stein dismissed stale reviews from zaviermiller and andlrutt via 9b56d70 May 1, 2024 18:53
@Frank-D-stein Frank-D-stein merged commit 09582a6 into main May 1, 2024
3 checks passed
@Frank-D-stein Frank-D-stein deleted the 252-add-frontend-support-for-updating-events branch May 1, 2024 19:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zaviermiller zaviermiller zaviermiller approved these changes

@andlrutt andlrutt andlrutt left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add frontend support for updating events
3 participants
@Frank-D-stein @zaviermiller @andlrutt