fix: some field not bein selialized

h2v9696 · Sep 8, 2024 · 71def0a · 71def0a
1 parent b6f7b69
commit 71def0a
Show file tree

Hide file tree

Showing 13 changed files with 21 additions and 14 deletions.
diff --git a/CHANGELOG.md.meta b/CHANGELOG.md.meta
diff --git a/LICENSE.meta b/LICENSE.meta
diff --git a/Runtime/EffectSystem/AdditionApplyEffects/GrantAbilityOnApplying.cs b/Runtime/EffectSystem/AdditionApplyEffects/GrantAbilityOnApplying.cs
@@ -6,6 +6,7 @@
 
 namespace H2V.GameplayAbilitySystem.EffectSystem.AdditionApplyEffects
 {
+    [Serializable]
     public class GrantAbilityOnApplying : IAdditionApplyEffect
     {
         /// <summary>

diff --git a/Runtime/EffectSystem/AdditionApplyEffects/GrantTagOnApplying.cs b/Runtime/EffectSystem/AdditionApplyEffects/GrantTagOnApplying.cs
@@ -5,6 +5,7 @@
 
 namespace H2V.GameplayAbilitySystem.EffectSystem.AdditionApplyEffects
 {
+    [Serializable]
     public class GrantTagOnApplying : IAdditionApplyEffect
     {
         /// <summary>

diff --git a/Runtime/EffectSystem/AdditionApplyEffects/RemoveOtherEffectOnAppliedByDef.cs b/Runtime/EffectSystem/AdditionApplyEffects/RemoveOtherEffectOnAppliedByDef.cs
@@ -4,13 +4,14 @@
 
 namespace H2V.GameplayAbilitySystem.EffectSystem.AdditionApplyEffects
 {
+    [Serializable]
     public class RemoveOtherEffectOnAppliedByDef : IAdditionApplyEffect
     {
         /// <summary>
         /// GameplayEffects on the Target that have any of these Defs
         /// will be removed from the Target when this GameplayEffect is successfully applied.
         /// </summary>
-        [field: SerializeField]
+        [field: SerializeReference]
         public IGameplayEffectDef[] EffectDefs { get; private set; } = Array.Empty<IGameplayEffectDef>();
 
         public void OnEffectSpecApplied(AbilitySystemComponent target)

diff --git a/Runtime/EffectSystem/AdditionApplyEffects/RemoveOtherEffectOnAppliedByTags.cs b/Runtime/EffectSystem/AdditionApplyEffects/RemoveOtherEffectOnAppliedByTags.cs
@@ -5,6 +5,7 @@
 
 namespace H2V.GameplayAbilitySystem.EffectSystem.AdditionApplyEffects
 {
+    [Serializable]
     public class RemoveOtherEffectOnAppliedByTags : IAdditionApplyEffect
     {
         /// <summary>

diff --git a/Runtime/EffectSystem/EffectCondition.cs → ...stem/EffectConditions/IEffectCondition.cs b/Runtime/EffectSystem/EffectCondition.cs → ...stem/EffectConditions/IEffectCondition.cs
@@ -1,4 +1,4 @@
-namespace H2V.GameplayAbilitySystem.EffectSystem
+namespace H2V.GameplayAbilitySystem.EffectSystem.EffectConditions
 {
     // Implement for custom conditions
     public interface IEffectCondition

diff --git a/Runtime/EffectSystem/EffectCondition.cs.meta → ...EffectConditions/IEffectCondition.cs.meta b/Runtime/EffectSystem/EffectCondition.cs.meta → ...EffectConditions/IEffectCondition.cs.meta
diff --git a/Runtime/EffectSystem/GameplayEffectDef.cs → Runtime/EffectSystem/IGameplayEffectDef.cs b/Runtime/EffectSystem/GameplayEffectDef.cs → Runtime/EffectSystem/IGameplayEffectDef.cs
@@ -1,5 +1,6 @@
 using H2V.GameplayAbilitySystem.Components;
 using H2V.GameplayAbilitySystem.EffectSystem.AdditionApplyEffects;
+using H2V.GameplayAbilitySystem.EffectSystem.EffectConditions;
 using H2V.GameplayAbilitySystem.EffectSystem.GamplayEffectPolicies;
 using H2V.GameplayAbilitySystem.EffectSystem.ScriptableObjects;
 using H2V.GameplayAbilitySystem.TagSystem.ScriptableObjects;

diff --git a/...me/EffectSystem/GameplayEffectDef.cs.meta → ...e/EffectSystem/IGameplayEffectDef.cs.meta b/...me/EffectSystem/GameplayEffectDef.cs.meta → ...e/EffectSystem/IGameplayEffectDef.cs.meta
diff --git a/Runtime/EffectSystem/ScriptableObjects/GameplayEffectSO.cs b/Runtime/EffectSystem/ScriptableObjects/GameplayEffectSO.cs
@@ -1,6 +1,7 @@
 using System;
 using H2V.GameplayAbilitySystem.Components;
 using H2V.GameplayAbilitySystem.EffectSystem.AdditionApplyEffects;
+using H2V.GameplayAbilitySystem.EffectSystem.EffectConditions;
 using H2V.GameplayAbilitySystem.EffectSystem.GamplayEffectPolicies;
 using H2V.GameplayAbilitySystem.TagSystem.ScriptableObjects;
 using UnityEngine;
@@ -33,8 +34,7 @@ public class GameplayEffectSO : ScriptableObject, IGameplayEffectDef
         [field: SerializeField]
         public StackingDetails StackingDetails { get; private set; }
 
-        [Tooltip("Addition effect when this effect is applied on the target")]
-        [field: SerializeReference, SubclassSelector]
+        [field: SerializeReference, SubclassSelector, Tooltip("Addition effect when this effect is applied on the target")]
         public IAdditionApplyEffect[] AdditionApplyEffects { get; private set; } = Array.Empty<IAdditionApplyEffect>();
 
         /// <summary>
@@ -43,8 +43,7 @@ public class GameplayEffectSO : ScriptableObject, IGameplayEffectDef
         [field: SerializeField, Tooltip("How the effect being execute with custom logic. Can leave it null.")]
         public EffectExecutionSO[] CustomExecutions { get; private set; } = Array.Empty<EffectExecutionSO>();
 
-        [Tooltip("Custom requirement to know if we can apply effect or not")]
-        [field: SerializeReference, SubclassSelector]
+        [field: SerializeReference, SubclassSelector, Tooltip("Custom requirement to know if we can apply effect or not")]
         public IEffectCondition[] ApplicationConditions { get; private set; } = Array.Empty<IEffectCondition>();
 
         /// <summary>

diff --git a/Runtime/EffectSystem/Utilities/GameplayEffectDefBuilder.cs b/Runtime/EffectSystem/Utilities/GameplayEffectDefBuilder.cs
@@ -1,6 +1,7 @@
 using System.Collections.Generic;
 using H2V.GameplayAbilitySystem.Components;
 using H2V.GameplayAbilitySystem.EffectSystem.AdditionApplyEffects;
+using H2V.GameplayAbilitySystem.EffectSystem.EffectConditions;
 using H2V.GameplayAbilitySystem.EffectSystem.GamplayEffectPolicies;
 using H2V.GameplayAbilitySystem.EffectSystem.ScriptableObjects;
 using H2V.GameplayAbilitySystem.TagSystem.ScriptableObjects;

diff --git a/package.json b/package.json
@@ -1,17 +1,12 @@
 {
-  "name": "com.h2v.gameplay-ability-system",
-  "version": "1.0.1",
+  "name": "h2v.gameplay-ability-system",
+  "version": "1.0.0",
   "displayName": "Gameplay Ability System",
   "description": "Gameplay Ability System from Unreal to Unity",
   "unity": "2022.3",
   "unityRelease": "0f1",
   "dependencies": {
     "com.mackysoft.serializereference-extensions": "1.1.9",
     "com.h2v.extensions-core": "0.0.1"
-  },
-  "author": {
-    "name": "H2V",
-    "email": "h2v9696@gmail.com",
-    "url": "https://github.com/h2v9696"
   }
 }