Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
aiohttp's
ClientResponse.raw_headers
is supposed to be "unconverted bytes".Pook was setting the keys and values of
raw_headers
asstring
instead ofbytes
.This was causing issues in clients which expect the headers to be
bytes
, for exampleaiobotocore
tries todecode()
header names and values which then fails withAttributeError: 'str' object has no attribute 'decode'
.See https://github.com/aio-libs/aiobotocore/blob/master/aiobotocore/endpoint.py#L41-L56
PR Checklist