Fix httpx incorrectly named method on interceptor subclass #126
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sarayourfriend
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #125
Co-authored-by: vincbo 84619931+vincbo@users.noreply.github.com
Kudos @vincbo for sharing the fix in the original issue.
I've wanted to add a suite of "standard" tests to run against each supported interceptor for a while. This PR adds that, in a minimal fashion, that will need to be expanded on, both to cover all the standard functionality for each supported HTTP client, and to create implementations for all explicitly supported clients. I only added implementations for the standard tests class for the clients that already had explicit tests.