Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

XX: workaround to use another array instead of passing an array section #54

Conversation

gxyd
Copy link
Owner

@gxyd gxyd commented Feb 13, 2025

we use a new allocatable array to pass as intent(inout) to the subroutine call

we use a new allocatable array to pass as intent(inout) to the subroutine
call
@gxyd gxyd merged commit fbb69c2 into build_pot3d_custom_mpi_wrappers_and_without_hdf5 Feb 13, 2025
2 checks passed
@gxyd gxyd deleted the workaround_array_section branch February 13, 2025 09:30
@adit4443ya
Copy link
Collaborator

Any specific reason why this workarund is needed @gxyd ?

@gxyd
Copy link
Owner Author

gxyd commented Feb 13, 2025

Any specific reason why this workarund is needed @gxyd ?

Because otherwise, LFortran produced incorrect value of positive flux (see: https://gist.github.com/gxyd/f4db2fed3dac8ffaec7031e98f6ce6fa#file-lfortran_log_output-log-L30), and hence incorrect output is produced.

Ofcourse, I still need to extract an MRE for this workaround, I tried using the workaround by guessing, and it worked, but still need to extract MRE so that we can eventually remove the workaround.

@gxyd
Copy link
Owner Author

gxyd commented Feb 21, 2025

Original issue in LFortran is reported here: lfortran/lfortran#6324

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants