feat: AddSolutionsModal #1334
Merged
feat: AddSolutionsModal #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
FBalint
force-pushed
the
guild-3400-add-solutions-to-the-current-add-reward-modal
branch
from
0f33d21 to
9c59652
Compare
…l' of github.com:guildxyz/guild.xyz into guild-3400-add-solutions-to-the-current-add-reward-modal
src/components/create-guild/PlatformsGrid/components/PlatformSelectButton.tsx
Outdated
Show resolved
Hide resolved
| @@ -18,6 +18,7 @@ const styles = { | |||
| }, | |||
| dialog: { | |||
| borderTopRadius: "xl", | |||
| backgroundColor: c === "dark" && darkBgColor, | |||
There was a problem hiding this comment.
Why do we need this? 👀
There was a problem hiding this comment.
By default, for dark mode, we separately color the header, body, and the footer of a modal. Sometimes, due to Chakra UI workings I did not yet uncover, these three have a slight spacing issue, and the dialog color behind them is shown, which made us think a divider was somehow added to the DOM.
There was a problem hiding this comment.
Ah, I see! Would be great to find the root of the issue, but if this will be the only blocker, let's do it this way & debug it later! ;)
dovalid
approved these changes
Jul 8, 2024
…solutions-to-the-current-add-reward-modal
dovalid
merged commit 65884b4
into
feat-liquidity-incentive-solution
1 of 2 checks passed
dovalid
deleted the
guild-3400-add-solutions-to-the-current-add-reward-modal
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
AddSolutionsButtonto smaller components, hooks