querySelector should escape ids #42
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
TIL!
It would be great to add a test in for this as well. |
* Introducing a fragment introduced edge-case which wasn't covered, so extra null guard added * For some reason linter/ts complaining so some fixups for that as well * Upped timeouts as my old laptop was struggling to run tests in time!
|
Thanks for updating the commit! I wasn't able to get around to adding the tests as quickly as I hoped. |
|
Thanks for contributing! Sorry for treading on toes, had a free spell and thought would add on as had some other bits planned anyway 😅 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
React.useId()the ID generated by the library looks something like":S1:"which breaks virtual guidepup as the querySelector does not escape the id. This change simply wraps the id inCSS.escapeReferenced React issue:
facebook/react#26839