-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
move from json encoders/decoders to elm-serialize's codecs #52
base: master
Are you sure you want to change the base?
Conversation
Conflicts: src/Builder/Build.elm src/Builder/Deps/Registry.elm src/Builder/Elm/Details.elm src/Builder/Generate.elm src/Builder/Reporting/Exit.elm src/Compiler/AST/Canonical.elm src/Compiler/AST/Optimized.elm src/Compiler/AST/Utils/Shader.elm src/Compiler/Elm/Compiler/Type/Extract.elm src/Compiler/Elm/Docs.elm src/Compiler/Elm/Interface.elm src/Compiler/Elm/Version.elm src/Compiler/Json/Decode.elm src/Compiler/Json/Encode.elm src/Compiler/Optimize/DecisionTree.elm src/Compiler/Reporting/Error/Canonicalize.elm src/Compiler/Reporting/Error/Import.elm src/Compiler/Reporting/Error/Type.elm src/Compiler/Reporting/Render/Type/Localizer.elm src/Compiler/Type/Error.elm src/Data/Map.elm src/Utils/Main.elm
Conflicts: src/Utils/Main.elm
This is extraordinary great work ! Congrats ! Out of curiosity, is it a goal to be exactly on par with ~/.elm ? |
@Warry Thank you! That means a lot! 😊 Glad you liked it!
At the moment that is not the intent, but I'm open to consider it if the right use case is presented. The initial implementation was done by using
Currently, we are focusing on performance. Let me know if this makes sense. |
No particular use case (I can use Elm to compile Elm), you've been very far in the immitation already ! It crossed my mind because I have written elmi and elmo decoder in the past (0.18 era), I know that it's quite annoying to debug. There have been tons of changes in 0.19.1 (UTF-8 in particular), and without the need for it anymore I didn't bother to port it.
I totally get it ! This is at most "nice to have". If it's not on your radar (well... because it's really peripheral), but you'd be open to pull request, I'd really like to at least figure out what's different, and see if there is a path moving forward. |
Even though the dependencies and modules are not exactly the same, I leave here the comparison between space taken in comparison between elm, JSON encoders/decoders, elm-serialize codecs:
Elm:
JSON encoders/decoders:
elm-serialize codecs:
Regarding the time it takes to run the test suites, here are the values:
JSON encoders/decoders:
elm-serialize codecs: