Remove any from useAsyncLoader
#1282
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,7 +39,7 @@ export function useAsyncLoader<T>( | |||
| asyncFetch() | |||
| .then((response) => responseProcessor(response)) | |||
| .then((data) => { | |||
| setData(data); | |||
| setData(data as T); | |||
There was a problem hiding this comment.
this is basically the crux of the refactor - using as to assert it's the type, since we're not parsing it at all
There was a problem hiding this comment.
Would it make sense to add some validation here before casting to T? Is there a pattern for doing that in this codebase already? We use zod in some other projects.
There was a problem hiding this comment.
yes, absolutely. Seemed like a step too far for this PR - but I think zod was just added to the codebase recently
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this change?
Trying to refactor to make sure we have no
anys in the theuseAsyncLoaderhook.How to test
How can we measure success?
Have we considered potential risks?
Images
Accessibility