Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove daysSinceLastScan as it is redundant with certifier interval #2080

Merged
merged 2 commits into from
Aug 18, 2024

Conversation

pxp928
Copy link
Collaborator

@pxp928 pxp928 commented Aug 16, 2024

Description of the PR

fixes #2077

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed, make generate has been run
  • If ent schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928 pxp928 requested a review from jeffmendoza as a code owner August 16, 2024 19:41
@pxp928 pxp928 requested a review from lumjjb August 16, 2024 19:44
Copy link
Collaborator

@mihaimaruseac mihaimaruseac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this makes sense, but leaving just a comment so that others get a chance to look at it too

@pxp928
Copy link
Collaborator Author

pxp928 commented Aug 16, 2024

Looks like I need to fix the e2e test here

…being called

Signed-off-by: pxp928 <parth.psu@gmail.com>
@pxp928
Copy link
Collaborator Author

pxp928 commented Aug 16, 2024

should be fixed now

@kodiakhq kodiakhq bot merged commit a3a7525 into guacsec:main Aug 18, 2024
8 checks passed
@pxp928 pxp928 deleted the pkg-component-revamp branch August 18, 2024 19:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[ingestion/clearlydefined] clearlydefined fails to run when the osv certifier has already run
4 participants