Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up isDependency query when spec depPkg has pkgID (add ent Pg index) #2020

Merged
merged 1 commit into from
Jul 16, 2024

Conversation

nchelluri
Copy link
Contributor

Description of the PR

I found that doing isDependency GQL queries where the filter had a dependent package spec with the package ID specified was slow, and adding this index sped it up a fair bit.

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed, make generate has been run
  • If ent schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

Signed-off-by: Narsimham Chelluri (Narsa) <narsa@kusari.dev>
@kodiakhq kodiakhq bot merged commit 2845fad into guacsec:main Jul 16, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants