Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated query known and slsa parser #2018

Merged
merged 6 commits into from
Jul 17, 2024
Merged

Conversation

Yaxhveer
Copy link
Contributor

Description of the PR

Fixes #2016
Fixes #2015

Updated known command for hasSBOM to check for packages with attached artifacts having sboms.
Updated getSlsaEntity to use subjects uri as PURL.

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed, make generate has been run
  • If ent schema is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, minor nit and adding a unit test.

@pull-request-size pull-request-size bot added size/L and removed size/M labels Jul 17, 2024
Signed-off-by: Yaxhveer <yaxhcod@gmail.com>
@Yaxhveer Yaxhveer requested a review from pxp928 July 17, 2024 08:09
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank You!

@pxp928 pxp928 requested review from mihaimaruseac and lumjjb July 17, 2024 12:36
@kodiakhq kodiakhq bot merged commit bc9361d into guacsec:main Jul 17, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
3 participants