Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Speed up common CertifyVuln ent queries by adding indexes #1999

Merged
merged 2 commits into from
Jul 3, 2024

Conversation

nchelluri
Copy link
Contributor

@nchelluri nchelluri commented Jul 2, 2024

Description of the PR

In our use of GUAC with the ent backend, we were noticing some high DB load from some CertifyVuln queries. This PR should help with that.

I also added a PR checklist item for next time:

  • If ent schema is changed, make generate has been run

PR Checklist

  • All commits have a Developer Certificate of Origin (DCO) -- they are generated using -s flag to git commit.
  • All new changes are covered by tests
  • If GraphQL schema is changed, make generate has been run
  • If GraphQL schema is changed, GraphQL client updates/additions have been made
  • If OpenAPI spec is changed, make generate has been run
  • If collectsub protobuf has been changed, make proto has been run
  • All CI checks are passing (tests and formatting)
  • All dependent PRs have already been merged

nchelluri added 2 commits July 2, 2024 17:00
Signed-off-by: Narsimham Chelluri (Narsa) <narsa@kusari.dev>
Signed-off-by: Narsimham Chelluri (Narsa) <narsa@kusari.dev>
@nchelluri nchelluri force-pushed the nchelluri/ent-indexes branch from e57337d to e76e0af Compare July 2, 2024 20:01
Copy link
Collaborator

@pxp928 pxp928 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thanks!

@pxp928 pxp928 requested a review from mrizzi July 2, 2024 20:17
Copy link
Collaborator

@mrizzi mrizzi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@nchelluri thanks!

@kodiakhq kodiakhq bot merged commit 0675b67 into guacsec:main Jul 3, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants