Skip to content

Commit

Permalink
spotbugs
Browse files Browse the repository at this point in the history
  • Loading branch information
@gtiwari333
gtiwari333 committed Sep 9, 2022
1 parent 2726985 commit 20f22d6
Show file tree
Hide file tree
Showing 14 changed files with 271 additions and 41 deletions.
0 ...-webapp/src/main/resources/checkstyle.xml → checkstyle.xml
View file
File renamed without changes.
18 changes: 18 additions & 0 deletions common/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -65,4 +65,22 @@
</dependency>
</dependencies>

<build>
<plugins>
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<excludeFilterFile>../spot-bugs.filter-exclude.xml</excludeFilterFile>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<configuration>
<configLocation>../checkstyle.xml</configLocation>
</configuration>
</plugin>
</plugins>
</build>
</project>
11 changes: 11 additions & 0 deletions content-checker/content-checker-service-model/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -27,4 +27,15 @@

</dependencies>

<build>
<plugins>
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<excludeFilterFile>../../spot-bugs.filter-exclude.xml</excludeFilterFile>
</configuration>
</plugin>
</plugins>
</build>
</project>
14 changes: 14 additions & 0 deletions content-checker/content-checker-service/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -57,6 +57,20 @@
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-maven-plugin</artifactId>
</plugin>
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<excludeFilterFile>../../spot-bugs.filter-exclude.xml</excludeFilterFile>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<configuration>
<configLocation>../../checkstyle.xml</configLocation>
</configuration>
</plugin>
</plugins>
</build>

Expand Down
18 changes: 18 additions & 0 deletions email/email-service-api/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,22 @@
</dependency>
</dependencies>

<build>
<plugins>
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<excludeFilterFile>../../spot-bugs.filter-exclude.xml</excludeFilterFile>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<configuration>
<configLocation>../checkstyle.xml</configLocation>
</configuration>
</plugin>
</plugins>
</build>
</project>
19 changes: 19 additions & 0 deletions email/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -19,5 +19,24 @@
<module>email-service-api</module>
</modules>

<build>
<plugins>
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<excludeFilterFile>../../spot-bugs.filter-exclude.xml</excludeFilterFile>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<configuration>
<configLocation>../../checkstyle.xml</configLocation>
</configuration>
</plugin>
</plugins>
</build>


</project>
14 changes: 14 additions & 0 deletions main-app/main-orm/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,20 @@
</dependency>
</dependencies>
</plugin>
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<excludeFilterFile>../../spot-bugs.filter-exclude.xml</excludeFilterFile>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<configuration>
<configLocation>../../checkstyle.xml</configLocation>
</configuration>
</plugin>
</plugins>
</build>

Expand Down
41 changes: 20 additions & 21 deletions main-app/main-webapp/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -249,18 +249,18 @@
</dependency>

<!--spring cloud contract stubs -->
<!-- <dependency>-->
<!-- <groupId>gt.app</groupId>-->
<!-- <artifactId>email-service</artifactId>-->
<!-- <classifier>stub</classifier>-->
<!-- <version>${project.parent.version}</version>-->
<!-- <exclusions>-->
<!-- <exclusion>-->
<!-- <groupId>*</groupId>-->
<!-- <artifactId>*</artifactId>-->
<!-- </exclusion>-->
<!-- </exclusions>-->
<!-- </dependency>-->
<!-- <dependency>-->
<!-- <groupId>gt.app</groupId>-->
<!-- <artifactId>email-service</artifactId>-->
<!-- <classifier>stub</classifier>-->
<!-- <version>${project.parent.version}</version>-->
<!-- <exclusions>-->
<!-- <exclusion>-->
<!-- <groupId>*</groupId>-->
<!-- <artifactId>*</artifactId>-->
<!-- </exclusion>-->
<!-- </exclusions>-->
<!-- </dependency>-->
<!-- test only dependencies -->
</dependencies>

Expand Down Expand Up @@ -339,20 +339,19 @@
</executions>
</plugin>

<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<excludeFilterFile>../../spot-bugs.filter-exclude.xml</excludeFilterFile>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>${maven.checkstyle.plugin.version}</version>
<configuration>
<configLocation>src/main/resources/checkstyle.xml</configLocation>
<configLocation>../../checkstyle.xml</configLocation>
</configuration>
<dependencies>
<dependency>
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
<version>${puppycrawl.checkstyle.version}</version>
</dependency>
</dependencies>
</plugin>

<plugin>
Expand Down
2 changes: 1 addition & 1 deletion main-app/main-webapp/src/main/java/gt/app/modules/user/UserService.java
View file
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ public void updateUserIfNeeded(User user) {
}

public User getReference(UUID id) {
return userRepository.getById(id);
return userRepository.getReferenceById(id);
}

public Optional<User> find(UUID id) {
Expand Down
14 changes: 14 additions & 0 deletions main-app/report-service/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -48,6 +48,20 @@
<groupId>org.springframework.boot</groupId>
<artifactId>spring-boot-maven-plugin</artifactId>
</plugin>
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<excludeFilterFile>../../spot-bugs.filter-exclude.xml</excludeFilterFile>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<configuration>
<configLocation>../../checkstyle.xml</configLocation>
</configuration>
</plugin>
</plugins>
</build>

Expand Down
105 changes: 86 additions & 19 deletions pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -60,6 +60,9 @@
<gmavenplus.version>1.13.1</gmavenplus.version>
<maven-processor-plugin.version>4.2</maven-processor-plugin.version>
<modernizer-maven-plugin.version>2.3.0</modernizer-maven-plugin.version>
<puppycrawl.checkstyle.config.file>src/main/resources/checkstyle.xml</puppycrawl.checkstyle.config.file>
<google.error-prone.compiler.version>2.14.0</google.error-prone.compiler.version>

</properties>


Expand Down Expand Up @@ -202,25 +205,89 @@
</dependencyManagement>

<build>
<plugins>
<plugin>
<groupId>org.gaul</groupId>
<artifactId>modernizer-maven-plugin</artifactId>
<version>${modernizer-maven-plugin.version}</version>
<executions>
<execution>
<id>modernizer</id>
<phase>package</phase>
<goals>
<goal>modernizer</goal>
</goals>
</execution>
</executions>
<configuration>
<javaVersion>${java.version}</javaVersion>
</configuration>
</plugin>
</plugins>
<pluginManagement>
<plugins>
<plugin>
<groupId>org.gaul</groupId>
<artifactId>modernizer-maven-plugin</artifactId>
<version>${modernizer-maven-plugin.version}</version>
<executions>
<execution>
<id>modernizer</id>
<phase>package</phase>
<goals>
<goal>modernizer</goal>
</goals>
</execution>
</executions>
<configuration>
<javaVersion>${java.version}</javaVersion>
</configuration>
</plugin>

<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<version>${maven.checkstyle.plugin.version}</version>
<configuration>
<configLocation>${puppycrawl.checkstyle.config.file}</configLocation>
</configuration>
<dependencies>
<dependency>
<groupId>com.puppycrawl.tools</groupId>
<artifactId>checkstyle</artifactId>
<version>${puppycrawl.checkstyle.version}</version>
</dependency>
</dependencies>
<executions>
<execution>
<id>verify-checkstyle</id>
<phase>test-compile</phase>
<goals>
<goal>check</goal>
</goals>
</execution>
</executions>
</plugin>

<plugin>
<groupId>org.gaul</groupId>
<artifactId>modernizer-maven-plugin</artifactId>
<version>${modernizer-maven-plugin.version}</version>
<executions>
<execution>
<id>modernizer</id>
<phase>test-compile</phase>
<goals>
<goal>modernizer</goal>
</goals>
</execution>
</executions>
<configuration>
<javaVersion>${java.version}</javaVersion>
<includeTestClasses>false</includeTestClasses>
</configuration>
</plugin>

<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<executions>
<execution>
<id>verify-spotbugs</id>
<phase>test-compile</phase>
<goals>
<goal>check</goal>
</goals>
</execution>
</executions>
<configuration>
<excludeFilterFile>spot-bugs.filter-exclude.xml</excludeFilterFile>
<includeTests>false</includeTests>
</configuration>
</plugin>
</plugins>
</pluginManagement>
</build>

<!-- <repositories>-->
Expand Down
23 changes: 23 additions & 0 deletions spot-bugs.filter-exclude.xml
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
<?xml version="1.0" encoding="UTF-8"?>

<FindBugsFilter>
<And>
<Bug category="MALICIOUS_CODE"/>
<Bug pattern="EI_EXPOSE_REP"/>
</And>
<And>
<Bug category="BAD_PRACTICE"/>
<Bug pattern="RV_RETURN_VALUE_IGNORED_BAD_PRACTICE"/>
</And>
<And>
<Bug category="MALICIOUS_CODE"/>
<Bug pattern="EI_EXPOSE_REP2"/>
</And>
<And>
<Bug category="BAD_PRACTICE"/>
<Bug pattern="SE_BAD_FIELD"/>
</And>
<Match>
<Source name="~generated-sources\..*"/>
</Match>
</FindBugsFilter>
18 changes: 18 additions & 0 deletions trend/trend-service-api/pom.xml
View file
Original file line number Diff line number Diff line change
Expand Up @@ -33,4 +33,22 @@
</dependency>
</dependencies>

<build>
<plugins>
<plugin>
<groupId>com.github.spotbugs</groupId>
<artifactId>spotbugs-maven-plugin</artifactId>
<configuration>
<excludeFilterFile>../../spot-bugs.filter-exclude.xml</excludeFilterFile>
</configuration>
</plugin>
<plugin>
<groupId>org.apache.maven.plugins</groupId>
<artifactId>maven-checkstyle-plugin</artifactId>
<configuration>
<configLocation>../../checkstyle.xml</configLocation>
</configuration>
</plugin>
</plugins>
</build>
</project>
Loading

0 comments on commit 20f22d6

Please sign in to comment.