added: unit tests on conraner id

grlt-hub · Nov 1, 2024 · 895468a · 895468a
1 parent 63347a6
commit 895468a
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 8 deletions.
diff --git a/...ontainer/__tests__/feature.deps.spec-d.ts → ...tainer/__tests__/container.deps.spec-d.ts b/...ontainer/__tests__/feature.deps.spec-d.ts → ...tainer/__tests__/container.deps.spec-d.ts
diff --git a/...eContainer/__tests__/feature.id.spec-d.ts → ...ontainer/__tests__/container.id.spec-d.ts b/...eContainer/__tests__/feature.id.spec-d.ts → ...ontainer/__tests__/container.id.spec-d.ts
@@ -1,6 +1,6 @@
 import { createContainer } from '../index';
 
-describe('feature.id not empty string', () => {
+describe('container.id not empty string', () => {
   test('happy', () => {
     createContainer({
       id: 'a',
@@ -10,7 +10,7 @@ describe('feature.id not empty string', () => {
 
   test('unhappy', () => {
     createContainer({
-      // @ts-expect-error feature id cannot be an empty string
+      // @ts-expect-error container.id cannot be an empty string
       id: '',
       onStart: () => ({ api: {} }),
     });

diff --git a/...ateContainer/__tests__/feature.id.spec.ts → ...eContainer/__tests__/container.id.spec.ts b/...ateContainer/__tests__/feature.id.spec.ts → ...eContainer/__tests__/container.id.spec.ts
@@ -2,7 +2,7 @@ import { createContainer, IDS_SET } from '../index';
 
 const onStart = () => ({ api: {} });
 
-describe('feature.id not empty string', () => {
+describe('container.id not empty string', () => {
   beforeEach(() => IDS_SET.clear());
 
   test('happy', () => {
@@ -12,15 +12,15 @@ describe('feature.id not empty string', () => {
   test('unhappy', () => {
     expect(() =>
       createContainer({
-        // @ts-expect-error feature id cannot be an empty string
+        // @ts-expect-error container.id cannot be an empty string
         id: '',
         onStart: () => ({ api: {} }),
       }),
     ).toThrowError('Container ID cannot be an empty string.');
   });
 });
 
-describe('feature.id is uniq', () => {
+describe('container.id is uniq', () => {
   beforeEach(() => IDS_SET.clear());
 
   test('happy', () => {

diff --git a/src/createContainer/index.ts b/src/createContainer/index.ts
@@ -18,7 +18,7 @@ type ExtractDeps<D extends Container<string, AnyObject>[]> = {
 };
 
 const ERROR = {
-  EMPTY_STRING_FEATURE_ID: 'Container ID cannot be an empty string.',
+  EMPTY_STRING_CONTAINER_ID: 'Container ID cannot be an empty string.',
   CONTAINER_ID_NOT_UNIQ: 'Container ID must be unique.',
 } as const;
 
@@ -32,7 +32,7 @@ type Params<
   Deps extends NonEmptyTuple<AnyContainer> | void = void,
   OptionalDeps extends NonEmptyTuple<AnyContainer> | void = void,
 > = '' extends Id
-  ? { id: never; error: typeof ERROR.EMPTY_STRING_FEATURE_ID }
+  ? { id: never; error: typeof ERROR.EMPTY_STRING_CONTAINER_ID }
   : Deps extends void
     ? OptionalDeps extends void
       ? {
@@ -81,7 +81,7 @@ const createContainer = <
   params: Params<Id, API, Deps, OptionalDeps>,
 ): Container<Id, API> => {
   if (params.id === '') {
-    throw new Error(ERROR.EMPTY_STRING_FEATURE_ID);
+    throw new Error(ERROR.EMPTY_STRING_CONTAINER_ID);
   }
 
   if (IDS_SET.has(params.id)) {