Allow padding fields to have duplicate names

gregorygaines · Dec 16, 2024 · 2e20f15 · 2e20f15
1 parent f3b5fb1
commit 2e20f15
Show file tree

Hide file tree

Showing 2 changed files with 15 additions and 1 deletion.
diff --git a/bitfields/tests/lib_tests.rs b/bitfields/tests/lib_tests.rs
@@ -450,6 +450,18 @@ mod tests {
         t.compile_fail("tests/compile_error_cases/bitfield_field_duplicate_name.rs");
     }
 
+    #[test]
+    fn bitfield_field_duplicate_padding_name() {
+        #[bitfield(u16)]
+        pub struct Bitfield {
+            a: u8,
+            #[bits(4)]
+            __: u8,
+            #[bits(4)]
+            __: u8,
+        }
+    }
+
     #[test]
     fn bitfield_field_padding() {
         #[bitfield(u64)]

diff --git a/bitfields_impl/src/lib.rs b/bitfields_impl/src/lib.rs
@@ -691,7 +691,9 @@ fn check_bitfield_names_unique(fields: &[BitfieldField]) -> syn::Result<()> {
                 ),
             ));
         }
-        field_names.push(field.name.clone());
+        if !field.padding {
+            field_names.push(field.name.clone());
+        }
     }
 
     Ok(())
-Original file line number
+Diff line change
@@ Expand Up @@
                     ),
                 ));
             }
-            field_names.push(field.name.clone());
+            if !field.padding {
+                field_names.push(field.name.clone());
+            }
         }
         Ok(())
@@ Expand Down @@