-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add: Allow Unlicense/MIT license #820
Conversation
Conventional Commits Report
🚀 Conventional commits found. |
@@ -42,4 +42,5 @@ runs: | |||
MIT OR Apache-2.0, | |||
MIT AND Python-2.0, | |||
(Apache-2.0 AND BSD-3-Clause) OR (Apache-2.0 AND MIT), | |||
(MIT OR Apache-2.0) AND Unicode-DFS-2016 | |||
(MIT OR Apache-2.0) AND Unicode-DFS-2016, | |||
Unlicense/MIT |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@jjnicola I don't think this is in the correct format and can not be recognized by the action ...
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As far as I can tell, https://github.com/BurntSushi/walkdir can be licensed under either Unlicense
or MIT
(see https://github.com/BurntSushi/walkdir/blob/master/README.md?plain=1#L11 ), both of which are already in the list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So the problem is rather that walkdir
uses a non-SPDX-compliant identifier for its license. The correct identifier should be Unlicense OR MIT
.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Correct! Nevertheless, this can not be "fixed" on our side!
b2af64f
to
a582301
Compare
@jjnicola did you get approval for this license? |
@greenbone/scanner-maintainers is this still required? Did you get approval? |
what approval? we still need that notation https://github.com/BurntSushi/walkdir/blob/master/Cargo.toml#L12 , yes. It is fair to assume that the author doesn't seem to care about SPDX-compliant notations as there is a PR open since 2021: |
This will currently not work anyway, as logically connected licenses are not a thing anymore, see #1197 |
Pull request was closed
What
Add: Allow Unlicense/MIT license
Why
Required by
walkdir
References
Checklist