Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/implement some various todos #446

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
Open

Refactor/implement some various todos #446

wants to merge 3 commits into from

Conversation

doriengr
Copy link
Contributor

@doriengr doriengr commented Feb 28, 2025 •
edited
Loading

refs #444

Stuff that was updated

  • moved filtering of users by role to storage layer
  • deleted todos that were already implemented or not needed anymore
  • handle error on mapping sensor data
  • asserted sensor data in sensor handler

@doriengr doriengr self-assigned this Feb 28, 2025
@doriengr doriengr marked this pull request as ready for review February 28, 2025 13:18
@doriengr doriengr added the need-reviewer Send notification in Discord label Feb 28, 2025
@xk0niR xk0niR requested a review from choffmann March 2, 2025 16:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choffmann choffmann Awaiting requested review from choffmann

At least 1 approving review is required to merge this pull request.

Assignees

@doriengr doriengr

Labels
need-reviewer Send notification in Discord
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@doriengr