Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: adjust TTN attribute names #440

Merged
merged 6 commits into from
Feb 26, 2025
Merged

fix: adjust TTN attribute names #440

merged 6 commits into from
Feb 26, 2025

Conversation

Mohammad96Assaf
Copy link
Contributor

@Mohammad96Assaf Mohammad96Assaf commented Feb 25, 2025 •
edited
Loading

close #439

@Mohammad96Assaf Mohammad96Assaf added the need-reviewer Send notification in Discord label Feb 25, 2025
@Mohammad96Assaf Mohammad96Assaf self-assigned this Feb 25, 2025
@Mohammad96Assaf Mohammad96Assaf force-pushed the fix/adjust-conversion-of-MQTT-payload branch from 4075eae to 98f8582 Compare February 26, 2025 15:35
@choffmann
Copy link
Member

Please also edit the dev, stage, prod and docker default config files and change the mqtt topic

@Mohammad96Assaf Mohammad96Assaf force-pushed the fix/adjust-conversion-of-MQTT-payload branch from cd6f1fb to cc902de Compare February 26, 2025 18:13
choffmann
choffmann approved these changes Feb 26, 2025
View reviewed changes
Copy link
Member

@choffmann choffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I implemented a safe cast and remove the condition when lat or long is zero the sensor will be inserted in the db now

@choffmann choffmann merged commit e90ee9c into develop Feb 26, 2025
4 checks passed
@choffmann choffmann deleted the fix/adjust-conversion-of-MQTT-payload branch February 26, 2025 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choffmann choffmann choffmann approved these changes

Assignees

@Mohammad96Assaf Mohammad96Assaf

Labels
need-reviewer Send notification in Discord
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adjust the conversion of the MQTT payload to make it compatible with TTN data
2 participants
@Mohammad96Assaf @choffmann