Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bugfix: fix conn busy err #436

Merged
merged 22 commits into from
Feb 24, 2025
Merged

bugfix: fix conn busy err #436

merged 22 commits into from
Feb 24, 2025

Conversation

choffmann
Copy link
Member

@choffmann choffmann commented Feb 24, 2025

Close #427
Close #429

This issue fixes common issues with multiple users working on the same object at the same time

@choffmann choffmann self-assigned this Feb 24, 2025
@choffmann choffmann force-pushed the bugfix/fix-conn-busy-err branch from fecaf8d to 7b0c259 Compare February 24, 2025 20:49
@choffmann choffmann marked this pull request as ready for review February 24, 2025 20:59
@choffmann choffmann added the need-reviewer Send notification in Discord label Feb 24, 2025
@xk0niR xk0niR requested review from xk0niR and removed request for xk0niR February 24, 2025 21:23
@choffmann choffmann force-pushed the bugfix/fix-conn-busy-err branch from 7b0c259 to 960de13 Compare February 24, 2025 21:52
Copy link
Contributor

@xk0niR xk0niR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What I tested:
Fill my database with tbz trees: OK

--- Easy Tests
vehicle: create/update/delete: OK
tree: create/update/delete: OK
treecluster: create/update/delete: OK
watering plan: create/update/delete: OK

sensors: There is no create or update (except manually editing database)
I deleted a sensor successfully with swagger: OK

--- Extended tests
Created treecluster t1 and treeclusgter t2

Tree from t1 to t2:

  • gets removed from t1: OK
  • gets added to t2: OK

I have also tested other functions without any error. 🥇

@choffmann choffmann merged commit 14ca656 into develop Feb 24, 2025
4 checks passed
@choffmann choffmann deleted the bugfix/fix-conn-busy-err branch February 24, 2025 22:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-reviewer Send notification in Discord
Projects
None yet
2 participants