-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update go1.24 #420
feat: update go1.24 #420
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Preperation:
-
Installed latest Go (go-2:1.24.0-1.1) on my computer
-
Clear my Go Folder (~/go)
-
Completly clear my docker installation
-- docker rm -vf $(docker ps -aq)
-- docker rmi -f $(docker images -aq) -
Different tests:
Test 'make clean': success
Test 'make setup': success
Test 'make generate': success
Test 'make lint' (make golangci-lint run'): success
Test 'go test ./...': error* (hint: make sure to run 'go clean -testcache' to clear cache!)
Test 'make infra/up': success (hint: use make config/dec to make sure to be on latest config)**
Test 'make migrate/up': success
Test 'make seed/up': success
Test 'make seed/reset': success
Test 'make migrate/reset': success
Test 'make run': success
** During Image Pulling I had a weird error with backend and also frontend.
E.g. during yarn generate:local but also during make infra/up
This is from yarn generate:local
"
[...]
Generating client using docker
Unable to find image 'openapitools/openapi-generator-cli:latest' locally
latest: Pulling from openapitools/openapi-generator-cli
[....]
8c51f7a21a73: Extracting [==================================================>] 1.113kB/1.113kB
docker: unexpected EOF.
See 'docker run --help'.
"
I am unable to consistently reproduce it. Running make infra/up or yarn generate:local again will fix this EOF issue...
** I am unable to consistently reproduce it....
Publish event 99
Publish event 100
2025/02/19 21:57:36 INFO starting event manager
Publish event 101
2025/02/19 21:57:36 INFO cleanup event manager
2025/02/19 21:57:37 ERROR error during initial process execution error="intentional error"
2025/02/19 21:57:37 ERROR error during process execution error="intentional error"
2025/02/19 21:57:37 ERROR error during process execution error="intentional error"
2025/02/19 21:57:37 ERROR error during process execution error="intentional error"
--- FAIL: TestSchedulerWithStruct (0.60s)
--- FAIL: TestSchedulerWithStruct/should_stop_execution_when_Stop()_is_called (0.30s)
scheduler_test.go:65:
Error Trace: /home/kon/project/green-ecolution-management/green-ecolution-backend/internal/worker/scheduler_test.go:65
Error: Not equal:
expected: 3
actual : 4
Test: TestSchedulerWithStruct/should_stop_execution_when_Stop()_is_called
Messages: Scheduler should stop executing Do() after Stop() is called
FAIL
FAIL github.com/green-ecolution/green-ecolution-backend/internal/worker 1.029s
ok github.com/green-ecolution/green-ecolution-backend/internal/worker/subscriber 0.012s
FAIL
I am sure both of these errors are not related to the new go version.
Should we maybe use another ticket for those?
@xk0niR Hmm... I tested it again by cleaning my docker images before. Tests are running and also in the pipeline. `docker: unexpected EOF' sounds like an internet problem to me as the image is pulled... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As in second post mentioned some errors which are not related to this issue and also "random". As of now approved!
2aca837
to
31e19f0
Compare
when using go tool, the deps are automatically downloaded and build when needed
change key size to 2048 https://pkg.go.dev/crypto/rsa#hdr-Minimum_key_size
31e19f0
to
d7a2d0d
Compare
Close #311
Close #419