Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/update watering status of tree cluster on sensor change #409

Merged

Conversation

doriengr
Copy link
Contributor

@doriengr doriengr commented Feb 10, 2025

Close #387

How to test it (frontend-wise):

  • select a tree cluster where one linked tree in the tree cluster has a sensor. Check which sensor is linked
  • select another tree cluster, select one random linked tree in the tree cluster and link the sensor to it that is currently linked to the tree in the first cluster and save your changes
  • check if both watering status values are updated. the tree cluster without any sensors should have now »unknown« as a watering status value

@doriengr doriengr self-assigned this Feb 10, 2025
@doriengr doriengr marked this pull request as ready for review February 10, 2025 11:29
@doriengr doriengr added the need-reviewer Send notification in Discord label Feb 10, 2025
@xk0niR xk0niR self-requested a review February 12, 2025 17:06
@doriengr doriengr force-pushed the fix/update-watering-status-of-tree-cluster-on-sensor-change branch from d2a107f to 4979288 Compare February 14, 2025 06:47
Copy link
Contributor

@xk0niR xk0niR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How I tested:

  • Create two treecluster tc1 and tc2

  • Assign tree t1 to tc1, assign tree t2 to tc2

  • Assign sensor s1 to t1
    => tc1 now shows "Sehr trocken" because of s1

  • Assign sensor s1 to t2
    => tc1 now shows "Unbekannt" because no sensor left.
    => tc2 now shows "Sehr trocken" because of s1

  • Assign sensor s1 to t1
    => tc1 now shows "Sehr trocken" because no sensor left.
    => tc2 now shows "Unbekannt" because of s1

Approved!

@doriengr doriengr merged commit b0fd0b6 into develop Feb 20, 2025
3 of 4 checks passed
@doriengr doriengr deleted the fix/update-watering-status-of-tree-cluster-on-sensor-change branch March 3, 2025 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
need-reviewer Send notification in Discord
Projects
None yet
2 participants