Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feature/add transactions for sensor repo #383

Merged
merged 3 commits into from
Jan 27, 2025
Merged

feature/add transactions for sensor repo #383

merged 3 commits into from
Jan 27, 2025

Conversation

Mohammad96Assaf
Copy link
Contributor

close #367
ref #85

@Mohammad96Assaf Mohammad96Assaf self-assigned this Jan 22, 2025
@Mohammad96Assaf Mohammad96Assaf added the need-reviewer Send notification in Discord label Jan 22, 2025
choffmann
choffmann reviewed Jan 26, 2025
View reviewed changes
Copy link
Member

@choffmann choffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Implementation looks good, I will review this again when its get rebased on develop

@choffmann
Copy link
Member

One thing, please remove the now used functions inside .../storage/postgres/sensor/sensor.go

functions like With...()

@Mohammad96Assaf Mohammad96Assaf force-pushed the feature/transactions-sensor-repo branch from 93b22d6 to fd58d52 Compare January 26, 2025 23:35
@Mohammad96Assaf Mohammad96Assaf force-pushed the feature/transactions-sensor-repo branch from a370dcb to af4c28c Compare January 27, 2025 23:08
@Mohammad96Assaf Mohammad96Assaf merged commit e01fb62 into develop Jan 27, 2025
4 checks passed
@Mohammad96Assaf Mohammad96Assaf deleted the feature/transactions-sensor-repo branch January 27, 2025 23:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choffmann choffmann choffmann approved these changes

Assignees

@Mohammad96Assaf Mohammad96Assaf

Labels
need-reviewer Send notification in Discord
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement transactions for sensor repository
2 participants
@Mohammad96Assaf @choffmann