Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/add tree cluster pagination #378

Merged
merged 20 commits into from
Jan 31, 2025
Merged

Feature/add tree cluster pagination #378

merged 20 commits into from
Jan 31, 2025

Conversation

doriengr
Copy link
Contributor

@doriengr doriengr commented Jan 20, 2025 •
edited
Loading

Close #370

@doriengr doriengr self-assigned this Jan 20, 2025
@doriengr doriengr mentioned this pull request Jan 20, 2025
Closed
@doriengr doriengr added the need-reviewer Send notification in Discord label Jan 20, 2025
@doriengr doriengr marked this pull request as ready for review January 20, 2025 14:13
@doriengr doriengr mentioned this pull request Jan 20, 2025
Merged
choffmann
choffmann reviewed Jan 25, 2025
View reviewed changes
Copy link
Member

@choffmann choffmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good so far 👍

internal/server/http/middleware/pagination.go Outdated Show resolved Hide resolved
internal/server/http/handler/v1/treecluster/handler.go Outdated Show resolved Hide resolved
@doriengr doriengr requested a review from choffmann January 26, 2025 12:30
@doriengr doriengr force-pushed the feature/add-tree-cluster-pagination branch 2 times, most recently from e37c11f to 6221e70 Compare January 26, 2025 13:26
choffmann
choffmann requested changes Jan 26, 2025
View reviewed changes
internal/storage/postgres/treecluster/get.go Outdated Show resolved Hide resolved
internal/storage/postgres/treecluster/get.go Outdated Show resolved Hide resolved
internal/storage/postgres/treecluster/get.go Outdated Show resolved Hide resolved
internal/storage/postgres/treecluster/get.go Outdated Show resolved Hide resolved
internal/storage/postgres/treecluster/get.go Outdated Show resolved Hide resolved
internal/utils/pagination.go Outdated Show resolved Hide resolved
internal/storage/postgres/treecluster/get.go Outdated Show resolved Hide resolved
internal/storage/postgres/treecluster/get.go Outdated Show resolved Hide resolved
internal/storage/postgres/treecluster/get.go Show resolved Hide resolved
@doriengr doriengr requested a review from choffmann January 26, 2025 16:39
@doriengr doriengr requested a review from choffmann January 27, 2025 19:55
@doriengr doriengr force-pushed the feature/add-tree-cluster-pagination branch from 7ca002e to 54baf7f Compare January 31, 2025 08:31
@doriengr doriengr merged commit 16f0b28 into develop Jan 31, 2025
4 checks passed
@doriengr doriengr deleted the feature/add-tree-cluster-pagination branch January 31, 2025 08:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@choffmann choffmann choffmann approved these changes

Assignees

@doriengr doriengr

Labels
need-reviewer Send notification in Discord
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Implement pagination for treecluster handler
2 participants
@doriengr @choffmann