feat: switch from mangodb to postgres #30
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
choffmann
requested changes
Aug 3, 2024
| @@ -10,7 +10,7 @@ const ( | |||
|
|
|||
| type SensorPredictionResponse struct { | |||
| SensorID string `json:"sensor_id"` | |||
| Tree *TreeResponse `json:"tree"` | |||
| Tree *TreeResponse `json:"treeSQL"` | |||
There was a problem hiding this comment.
Why treeSQL? Please let it by tree
Suggested change
| Tree *TreeResponse `json:"treeSQL"` | |
| Tree *TreeResponse `json:"tree"` |
| @@ -3,12 +3,12 @@ package tree | |||
| import "github.com/green-ecolution/green-ecolution-backend/internal/server/http/entities/sensor" | |||
|
|
|||
| type TreeSensorPredictionResponse struct { | |||
| Tree *TreeResponse `json:"tree,omitempty"` | |||
| Tree *TreeResponse `json:"treeSQL,omitempty"` | |||
There was a problem hiding this comment.
Suggested change
| Tree *TreeResponse `json:"treeSQL,omitempty"` | |
| Tree *TreeResponse `json:"tree,omitempty"` |
| SensorPrediction *SensorPredictionResponse `json:"sensor_prediction,omitempty"` | ||
| SensorData []*sensor.MqttPayloadResponse `json:"sensor_data,omitempty" extensions:"x-nullable"` | ||
| } // @Name TreeSensorPrediction | ||
|
|
||
| type TreeSensorDataResponse struct { | ||
| Tree *TreeResponse `json:"tree,omitempty"` | ||
| Tree *TreeResponse `json:"treeSQL,omitempty"` |
There was a problem hiding this comment.
Suggested change
| Tree *TreeResponse `json:"treeSQL,omitempty"` | |
| Tree *TreeResponse `json:"tree,omitempty"` |
| SensorPrediction *SensorPredictionResponse `json:"sensor_prediction,omitempty"` | ||
| SensorData []*sensor.MqttPayloadResponse `json:"sensor_data,omitempty" extensions:"x-nullable"` | ||
| } // @Name TreeSensorPrediction | ||
|
|
||
| type TreeSensorDataResponse struct { | ||
| Tree *TreeResponse `json:"tree,omitempty"` | ||
| Tree *TreeResponse `json:"treeSQL,omitempty"` |
There was a problem hiding this comment.
Suggested change
| Tree *TreeResponse `json:"treeSQL,omitempty"` | |
| Tree *TreeResponse `json:"tree,omitempty"` |
Comment on lines
+16
to
+17
| // @Param sensor_data query boolean false "Get raw sensorSQL data for each treeSQL" | ||
| // @Success 200 {object} []treeSQL.TreeSensorDataResponse |
There was a problem hiding this comment.
Suggested change
| // @Param sensor_data query boolean false "Get raw sensorSQL data for each treeSQL" | |
| // @Success 200 {object} []treeSQL.TreeSensorDataResponse | |
| // @Param sensor_data query boolean false "Get raw sensor data for each tree" | |
| // @Success 200 {object} []tree.TreeSensorDataResponse |
| return data, nil | ||
| } | ||
|
|
||
| func (r *TreeRepository) GetAll(ctx context.Context) ([]*tree.TreeEntity, error) { |
There was a problem hiding this comment.
Return the domain entity
Suggested change
| func (r *TreeRepository) GetAll(ctx context.Context) ([]*tree.TreeEntity, error) { | |
| func (r *TreeRepository) GetAll(ctx context.Context) ([]*tree.Tree, error) { |
There was a problem hiding this comment.
Inside the mapper, remove the mongodb stuff
| func (r *SchemaRepository) SetupSensorTable() { | ||
| _, err := r.db.Exec(` | ||
| CREATE TABLE IF NOT EXISTS sensors ( | ||
| id UUID PRIMARY KEY, |
There was a problem hiding this comment.
We should not use uuid's in a sql database as the primary key
| type Repository struct { | ||
| Info InfoRepository | ||
| Sensor SensorRepository | ||
| Tree TreeRepository | ||
| Schema SchemaRepository |
| @@ -75,6 +75,7 @@ func main() { | |||
| Info: localRepo.Info, | |||
| Sensor: dbRepo.Sensor, | |||
| Tree: dbRepo.Tree, | |||
| Schema: dbRepo.Schema, | |||
choffmann
requested changes
Aug 3, 2024
There was a problem hiding this comment.
Please implement the feedback. I can't test the application because it won't build and there are some issues I mentioned in the review. If you have fixed them, I would like to do another review.
In general, you only need to work within the storage layer/directory, so the other layers shouldn't be updated.
choffmann
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
swithching from mangodb to postgreSQL
Close #6