fix: return error on wrong update

green-ecolution · Jan 26, 2025 · 9bd8c83 · 9bd8c83
1 parent ee5bf13
commit 9bd8c83
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 1 deletion.
diff --git a/internal/service/domain/tree/handle_new_sensor_data.go b/internal/service/domain/tree/handle_new_sensor_data.go
@@ -28,6 +28,7 @@ func (s *TreeService) HandleNewSensorData(ctx context.Context, event *entities.E
 	newTree, err := s.treeRepo.Update(ctx, t.ID, tree.WithWateringStatus(status))
 	if err != nil {
 		log.Error("failed to update tree with new watering status", "tree_id", t.ID, "watering_status", status, "err", err)
+		return err
 	}
 
 	slog.Info("updating tree watering status", "prev_status", t.WateringStatus, "new_status", status)

diff --git a/internal/service/domain/tree/handle_new_sensor_data_test.go b/internal/service/domain/tree/handle_new_sensor_data_test.go
@@ -151,7 +151,7 @@ func TestTreeService_HandleNewSensorData(t *testing.T) {
 		err := svc.HandleNewSensorData(context.Background(), &event)
 
 		// then
-		assert.NoError(t, err)
+		assert.ErrorIs(t, err, storage.ErrTreeNotFound)
 		select {
 		case <-ch:
 			t.Fatal("event was received. It should not have been sent")