Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing shop=jewellery #4988

Merged
merged 2 commits into from
Jul 7, 2024
Merged

Removing shop=jewellery #4988

merged 2 commits into from
Jul 7, 2024

Conversation

BubbaJuice
Copy link
Contributor

Fixes #4962

Changes proposed in this pull request:

  • Removes specialized rendering of shop=jewellery

Test rendering at z19 with links to the example places:

Parramatta, Australia
Before
ZfignBWh

After
b4BdXrtU

Copy link
Collaborator

@pnorman pnorman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Other than the line reformatting I'm okay with this but have not yet tested.

project.mml Outdated
'computer', 'confectionery', 'fashion', 'convenience', 'department_store', 'doityourself', 'hardware',
'fabric', 'fishmonger', 'florist', 'garden_centre', 'hairdresser', 'hifi', 'car', 'car_repair', 'bicycle',
'mall', 'pet', 'photo', 'photo_studio', 'photography', 'seafood', 'shoes', 'alcohol', 'gift', 'furniture',
'kiosk', 'mobile_phone', 'motorcycle', 'musical_instrument', 'newsagent', 'optician', 'jewelry',
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you remove the rewrapping of the other lines so this part of the diff is just one line?

I'd rather have uneven line lengths than more difficulty with git bisect

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, sorry.

@BubbaJuice BubbaJuice marked this pull request as ready for review July 3, 2024 04:40
@BubbaJuice BubbaJuice requested a review from pnorman July 3, 2024 14:46
Copy link
Collaborator

@imagico imagico left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good and works as intended.

Before:
before

After:
after

@pnorman pnorman merged commit 23b1cfa into gravitystorm:master Jul 7, 2024
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove rendering of shop=jewellery (but keep jewelry)
3 participants