Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add missing icons & update web3icons validation logic #84

Merged
merged 8 commits into from
Feb 20, 2025
Merged

add missing icons & update web3icons validation logic #84

merged 8 commits into from
Feb 20, 2025

Conversation

0xa3k5
Copy link
Member

@0xa3k5 0xa3k5 commented Feb 19, 2025 •
edited
Loading

  • added missing icons for: lens, botanix, expchain, mantra

  • updated the web3icons type and interfaces to match the library

  • updated the web3icons validation logic to better match the icons

  • Use a meaningful title for the pull request

  • Increment package.json version

  • Pass validation checks

@0xa3k5 0xa3k5 requested a review from YaroShkvorets February 19, 2025 22:01
YaroShkvorets
YaroShkvorets approved these changes Feb 20, 2025
View reviewed changes
Copy link
Collaborator

@YaroShkvorets YaroShkvorets left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR, tweaked a bit icon validation now that there are 3 variants.

@YaroShkvorets YaroShkvorets merged commit b039317 into main Feb 20, 2025
2 checks passed
@YaroShkvorets YaroShkvorets deleted the update-icons branch February 20, 2025 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@YaroShkvorets YaroShkvorets YaroShkvorets approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@0xa3k5 @YaroShkvorets