-
Notifications
You must be signed in to change notification settings - Fork 999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rework generation of the VID #5737
base: zoran/rename-structs
Are you sure you want to change the base?
Rework generation of the VID #5737
Conversation
1bbef27
to
5910d01
Compare
632ef9f
to
9658d8c
Compare
9e6aa6d
to
02ce854
Compare
02ce854
to
62d1e2b
Compare
11c68a7
to
950a0fd
Compare
5151b66
to
b6f7492
Compare
b6f7492
to
640e7d1
Compare
@lutter I've decided to go that route. It simplifies the code a lot. Also I've added a check in the Finally when deserializing the entities from the database, I added deserialization of the the Those are two major changes since your last review. |
6feee8e
to
14671db
Compare
14671db
to
640e7d1
Compare
14671db
to
640e7d1
Compare
This PR changes the generation of the VID in such a way that entities have an order determined by the order of the blockchain transactions from which they originate, rather than to be ordered by the current implementation of the graph-node and the VID autogenerated by the database. This in turn will ensure that the dependant subgraphs would have a deterministic order of their input entities and it would be consistent across different graph-node deployments producing the same POI.