Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(VueUiDonut): bug in the synchronization of animation and data #141

Merged
merged 1 commit into from
Dec 19, 2024

Conversation

mnenie
Copy link
Contributor

@mnenie mnenie commented Dec 19, 2024

hi @graphieros !
I really like this library, but recently I found a bug in VueUiDonut
so, with multiple clicks on on legend items, we get a consumption of percent from 100 due to the fact that the data does not have time to be updated and unforeseen situations occur
my solution to the problem is to call segregate with isAnimating.value at false only - wait for the animation to pass and allow the user to interact with legend again

before:
Снимок экрана 2024-12-19 205016

after:
the variable is calculated correctly while waiting for the animation to pass
Снимок экрана 2024-12-19 205109

Copy link
Owner

@graphieros graphieros left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's very clean:)

@graphieros graphieros merged commit 25f5924 into graphieros:master Dec 19, 2024
@graphieros
Copy link
Owner

@mnenie

v2.4.44
Also live on the docs website

Thanks again!

@graphieros graphieros added bug : layout Chart layout presents a defect reactivity Questions related to reactivity labels Dec 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug : layout Chart layout presents a defect reactivity Questions related to reactivity
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants