Fix incorrect choices length in attestation packing

grandinetech · Apr 17, 2024 · 717551c · 717551c
1 parent a223216
commit 717551c
Showing 1 changed file with 7 additions and 6 deletions.
diff --git a/operation_pools/src/attestation_agg_pool/attestation_packer.rs b/operation_pools/src/attestation_agg_pool/attestation_packer.rs
@@ -293,6 +293,8 @@ impl<P: Preset> AttestationPacker<P> {
                         choices.push(attestation_choice);
                         values.push(weight);
                         best_weight = weight;
+                    } else {
+                        break;
                     }
                 }
             }
@@ -375,14 +377,13 @@ impl<P: Preset> AttestationPacker<P> {
             att_selected = prev[groups_analyzed][att_selected];
         }
 
+        attestations.truncate(P::MaxAttestations::USIZE);
+
         PackOutcome {
-            attestations: attestations
-                .into_iter()
-                .pipe(ContiguousList::try_from_iter)
-                .expect(
-                    "the call to Iterator::take limits the number \
+            attestations: attestations.try_into().expect(
+                "the call to Vec::truncate limits the number \
                  of attestations to P::MaxAttestations::USIZE",
-                ),
+            ),
             deadline_reached: self.deadline_reached(),
         }
     }